diff options
| author | Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 2013-05-28 14:26:29 +0200 |
|---|---|---|
| committer | Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 2013-05-31 19:15:22 +0200 |
| commit | a7a0425de7b1933fc53f1f5f3f3309adebd892bb (patch) | |
| tree | a22fb0b83552db8c2ffb02f27ac0b035a658722d | |
| parent | 679775ae2d5bda73e4b973cf2dcebce6df33dca4 (diff) | |
| download | ceph-a7a0425de7b1933fc53f1f5f3f3309adebd892bb.tar.gz | |
bench/dumb_backend.cc: check return value of posix_fadvise()
CID 743396 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)
check_return: Calling function "posix_fadvise(fd, offset, bl->length(), 4)"
without checking return value. This library function may fail and return
an error code.
unchecked_value: No check of the return value of
"posix_fadvise(fd, offset, bl->length(), 4)".
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| -rw-r--r-- | src/test/bench/dumb_backend.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/test/bench/dumb_backend.cc b/src/test/bench/dumb_backend.cc index a763c45f0c8..170fee7fab6 100644 --- a/src/test/bench/dumb_backend.cc +++ b/src/test/bench/dumb_backend.cc @@ -30,9 +30,12 @@ void DumbBackend::_write( if (do_sync_file_range) ::sync_file_range(fd, offset, bl.length(), SYNC_FILE_RANGE_WAIT_AFTER); - if (do_fadvise) - ::posix_fadvise(fd, offset, bl.length(), - POSIX_FADV_DONTNEED); + if (do_fadvise) { + int fa_r = posix_fadvise(fd, offset, bl.length(), POSIX_FADV_DONTNEED); + if (fa_r) { + std::cout << "posix_fadvise failed, errno is: " << fa_r << std::endl; + } + } ::close(fd); { Mutex::Locker l(pending_commit_mutex); |