summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Farnum <greg@inktank.com>2012-11-28 16:26:54 -0800
committerGreg Farnum <greg@inktank.com>2012-11-28 16:28:58 -0800
commit24d61fa4196b7a7bbf14de3bb81624ef378f7577 (patch)
treed5ead988cad6fb14ba06c3b2ede750e4d0ea8699
parentc762f91a512a59c0a187afd88e6a5cebe7aeb2d7 (diff)
downloadceph-24d61fa4196b7a7bbf14de3bb81624ef378f7577.tar.gz
mon: add WARN_UNUSED_RESULT to the MonitorStore functions that return error codes
Signed-off-by: Greg Farnum <greg@inktank.com>
-rw-r--r--src/mon/MonitorStore.h10
1 files changed, 6 insertions, 4 deletions
diff --git a/src/mon/MonitorStore.h b/src/mon/MonitorStore.h
index 2e5cf0af6e6..9d1efde3d53 100644
--- a/src/mon/MonitorStore.h
+++ b/src/mon/MonitorStore.h
@@ -18,6 +18,8 @@
#include "include/types.h"
#include "include/buffer.h"
+#include "common/compiler_extensions.h"
+
#include <iosfwd>
#include <string.h>
#include <errno.h>
@@ -38,16 +40,16 @@ public:
void sync();
// ints (stored as ascii)
- version_t get_int(const char *a, const char *b=0);
+ version_t get_int(const char *a, const char *b=0) WARN_UNUSED_RESULT;
void put_int(version_t v, const char *a, const char *b=0);
- version_t get_global_version(const char *a, version_t b);
+ version_t get_global_version(const char *a, version_t b) WARN_UNUSED_RESULT;
void put_global_version(const char *a, version_t b, version_t gv);
// buffers
// ss and sn varieties.
bool exists_bl_ss(const char *a, const char *b=0);
- int get_bl_ss(bufferlist& bl, const char *a, const char *b);
+ int get_bl_ss(bufferlist& bl, const char *a, const char *b) WARN_UNUSED_RESULT;
void get_bl_ss_safe(bufferlist& bl, const char *a, const char *b) {
int ret = get_bl_ss(bl, a, b);
assert (ret >= 0 || ret == -ENOENT);
@@ -63,7 +65,7 @@ public:
snprintf(bs, sizeof(bs), "%llu", (unsigned long long)b);
return exists_bl_ss(a, bs);
}
- int get_bl_sn(bufferlist& bl, const char *a, version_t b) {
+ int get_bl_sn(bufferlist& bl, const char *a, version_t b) WARN_UNUSED_RESULT {
char bs[20];
snprintf(bs, sizeof(bs), "%llu", (unsigned long long)b);
return get_bl_ss(bl, a, bs);