summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSage Weil <sage@inktank.com>2013-10-06 15:12:57 -0700
committerSage Weil <sage@inktank.com>2013-10-06 15:17:50 -0700
commitf27964189419f590c5025c515986b1a3af5e2748 (patch)
tree8871014ae2027cd0309bfd8da2523e113fc8b4eb
parent92a60a05841397aa0c59a1097e133eaca27ca532 (diff)
downloadceph-f27964189419f590c5025c515986b1a3af5e2748.tar.gz
mon: do not put() unhandle message
If we return false because we aren't handling a message, we should not put the ref. This fixes a double-free. Signed-off-by: Sage Weil <sage@inktank.com>
-rw-r--r--src/mon/Monitor.cc1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 3fe658d9623..aea81102720 100644
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -2586,7 +2586,6 @@ bool Monitor::_ms_dispatch(Message *m)
if (!src_is_mon && m->get_type() != CEPH_MSG_AUTH) {
dout(1) << __func__ << " dropping stray message " << *m
<< " from " << m->get_source_inst() << dendl;
- m->put();
return false;
}