diff options
| author | Colin Patrick McCabe <cmccabe@alumni.cmu.edu> | 2010-12-30 00:09:11 -0800 |
|---|---|---|
| committer | Colin Patrick McCabe <cmccabe@alumni.cmu.edu> | 2010-12-30 10:38:36 -0800 |
| commit | c846615d8b226df034d970f04bdb3201b61bfbb1 (patch) | |
| tree | 1869251a98e0d2b5b788ea7e24173ebdcf6f5e01 /qa/rbd | |
| parent | 634cca9530c549845696b2869f35770e8b00f9fa (diff) | |
| download | ceph-c846615d8b226df034d970f04bdb3201b61bfbb1.tar.gz | |
qa: rbd: small optimization to script
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
Diffstat (limited to 'qa/rbd')
| -rw-r--r-- | qa/rbd/common.sh | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/qa/rbd/common.sh b/qa/rbd/common.sh index 14e8c67ad9a..aa6efe7de83 100644 --- a/qa/rbd/common.sh +++ b/qa/rbd/common.sh @@ -67,9 +67,10 @@ rbd_add() { pushd /sys/bus/rbd/devices &> /dev/null [ $? -eq 0 ] || die "failed to cd" devid="" - # We 'should' start at the end (sorting numerically) - # TODO: rewrite this to be more efficient if it's important - for f in *; do + rm -f "$TDIR/rbd_devs" + for f in *; do echo $f >> "$TDIR/rbd_devs"; done + sort -nr "$TDIR/rbd_devs" > "$TDIR/rev_rbd_devs" + while read f < "$TDIR/rev_rbd_devs"; do read d_img_name < "$f/name" if [ "x$d_img_name" == "x$img_name.$id" ]; then devid=$f |