diff options
author | Colin Patrick McCabe <cmccabe@alumni.cmu.edu> | 2010-11-18 14:51:18 -0800 |
---|---|---|
committer | Colin Patrick McCabe <cmccabe@alumni.cmu.edu> | 2010-11-18 15:05:29 -0800 |
commit | 6e2b594b3329cb08bf54cd325776b236f2e6c4f1 (patch) | |
tree | 30bfd2878b9bf272a49b156e32bf97684095c2bf /src/multi-dump.sh | |
parent | 43e0b2670b24186c055ace94b1743a2017073a7c (diff) | |
download | ceph-6e2b594b3329cb08bf54cd325776b236f2e6c4f1.tar.gz |
ReplicatedPG::get_object_contect: fix broken calls
ReplicatedPG::get_object_context takes three parameters. The last two
are "const object_locator_t& oloc" and "bool can_create".
Unfortunately, booleans can degrade to ints, and ints can be used to
initialize objects of type object_locator_t.
So when you make a call like:
> ctx->snapset_obc = get_object_context(snapoid, true);
What happens is that you actually call:
> get_object_context(snapoid, object_locator(1), false);
So you pass an invalid and *not* blank object_locator_t, and pass false
for can_create. This is not what the caller wanted. This change gets rid
of the default parameters and fixes the callers.
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
Diffstat (limited to 'src/multi-dump.sh')
0 files changed, 0 insertions, 0 deletions