summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* assert deleted keys are gonewip-5754Sage Weil2013-07-271-0/+9
|
* Merge pull request #471 from dalgaaf/wip-da-fix-pylintSage Weil2013-07-275-12/+10
|\ | | | | | | | | Cleanup minor issues from pylint Reviewed-by: Sage Weil <sage@inktank.com>
| * pybind/rbd.py: remove unused import of 'pointer'Danny Al-Gaaf2013-07-271-1/+1
| | | | | | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * cephfs.py: remove unused importsDanny Al-Gaaf2013-07-271-3/+1
| | | | | | | | | | | | | | Removed ctypes, c_uint64, c_ubyte, pointer, CFUNCTYPE since they are not used in the code. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * rados.py: fix bad indentationDanny Al-Gaaf2013-07-271-1/+1
| | | | | | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * ceph_argparse.py: add missing spaces after commaDanny Al-Gaaf2013-07-271-3/+3
| | | | | | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * ceph_argparse.py: remove unnecessary semicolonsDanny Al-Gaaf2013-07-271-3/+3
| | | | | | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * ceph_rest_api.py: fix bad indentationDanny Al-Gaaf2013-07-271-1/+1
|/ | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* test/admin_socket: fix admin_socket unit testsSage Weil2013-07-261-9/+9
| | | | | | Command is now JSON! Signed-off-by: Sage Weil <sage@inktank.com>
* rgw: fix RGWFormatter_PlainSage Weil2013-07-261-0/+3
| | | | | | Needs dump_format_unqouted. Signed-off-by: Sage Weil <sage@inktank.com>
* common/admin_socket: do not populate empty help stringsSage Weil2013-07-261-3/+3
| | | | | | | Hidden commands have no help string. Make this consistent: the m_help entry is always there, but may be empty. Signed-off-by: Sage Weil <sage@inktank.com>
* common/perf_counters: fix unit testsSage Weil2013-07-261-23/+23
| | | | | | The commands are now in json. Signed-off-by: Sage Weil <sage@inktank.com>
* common/perf_counters: fix missing decimal in time, quotingSage Weil2013-07-261-10/+10
| | | | | | | We shouldn't quote integer or float values. Also easier to use dump_unsigned. Signed-off-by: Sage Weil <sage@inktank.com>
* common/Formatter: add dump_format_unquoted()Sage Weil2013-07-262-0/+30
| | | | | | | Sometimes a savvy caller wants to format the output but doesn't want it quoted. Signed-off-by: Sage Weil <sage@inktank.com>
* rados.py: missing parameter to make_ex()Dan Mick2013-07-261-1/+1
| | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
* ceph-rest-api: clean up options/environmentDan Mick2013-07-264-220/+188
| | | | | | | | | | | | | | | | | | | ceph-rest-api: * create app from wrapper by calling generate_app() * pass args to generate_app() (early parsed in wrapper) * parse -i/--id here as well * set addr:port on returned app object * handle only EnvironmentError exceptions; let others spew traceback * turn off debug when running singlethreaded server ceph_rest_api.py: * put glob.* on app.ceph_* instead; pass around app in init code * drop conf parsing (let librados do its job) Documentation updated to match. Signed-off-by: Dan Mick <dan.mick@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
* qa/fs/.gitignoreSage Weil2013-07-261-0/+1
| | | | Signed-off-by: Sage Weil <sage@inktank.com>
* ceph_test_admin_socket: fix unit testSage Weil2013-07-261-2/+2
| | | | Signed-off-by: Sage Weil <sage@inktank.com>
* message: Fix asserts that dont' triggerDavid Zafman2013-07-262-2/+2
| | | | | Signed-off-by: David Zafman <david.zafman@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
* librados: EINVAL on a negative osd idSage Weil2013-07-261-0/+4
| | | | Signed-off-by: Sage Weil <sage@inktank.com>
* ceph.in: make osdids() (and mon, mds) work on old monsDan Mick2013-07-261-0/+11
| | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
* osd: humor coveritySage Weil2013-07-262-3/+6
| | | | | | | | | | | | | CID 1058392: Out-of-bounds access (OVERRUN_DYNAMIC) [select issue] CID 1058391 (#1 of 1): Out-of-bounds access (OVERRUN) 32. alloc_strlen: Allocating insufficient memory for the terminating null of the string. CID 1058390 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) 13. check_return: Calling function "this->class_handler->open_all_classes()" without checking return value. It wraps a library function that may fail and return an error code. [show details] 14. unchecked_value: No check of the return value of "this->class_handler->open_all_classes()". Signed-off-by: Sage Weil <sage@inktank.com>
* mon/MonCap: mds needs to subscribe to the osdmapSage Weil2013-07-261-0/+1
| | | | | | | | Usually it can get it from the OSD, but it assumes the mon will also share and doesn't behave when it does not. Fixes: #5767 Signed-off-by: Sage Weil <sage@inktank.com>
* remove unused fiemap codeSage Weil2013-07-267-138/+2
| | | | Signed-off-by: Sage Weil <sage@inktank.com>
* PendingReleaseNotes: note on 'ceph tell <pgid> ...'Sage Weil2013-07-261-0/+7
| | | | Signed-off-by: Sage Weil <sage@inktank.com>
* Merge remote-tracking branch 'gh/wip-tell-unified' into nextSage Weil2013-07-2625-530/+805
|\ | | | | | | Reviewed-by: Sage Weil <sage@inktank.com>
| * ceph_rest_api.py: cleanup, more docstrings, unused varsDan Mick2013-07-261-28/+52
| | | | | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * ceph_argparse.py: make find_cmd_target handle tell <pgid>Dan Mick2013-07-261-2/+17
| | | | | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * ceph_argparse, mon: make "tell <pgid>" work (duplicating "pg <pgid>")Dan Mick2013-07-263-11/+35
| | | | | | | | | | | | | | It's a wad of special cases, but it implements "tell <pgid>" such that it has the same effect as "pg <pgid>". Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * ceph_rest_api.py: obtain and handle tell <osd-or-pgid> commandsDan Mick2013-07-263-93/+229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Contact an OSD that's up to get a list of the commands, and use them to add to the URL map. Special treatment throughout for these commands: * hack the help signature dump * keep a 'flavor' per command to allow special handler() processing * strip off 'tell/<target>' when constructing command * allow multiple dicts with the same url (the parameters and get/put methods can change) * because of above, method must be validated in handler() * validate the given OSD * calculate target for command (mon, osd, pg) Unrelated: make method_dict into global METHOD_DICT Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * PG: add formatted output to pg <pgid> query, list_missingDan Mick2013-07-263-62/+53
| | | | | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * OSD: "tell <osd.n>" version, bench, dump_pg_recovery_stats: formattedDan Mick2013-07-262-7/+61
| | | | | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * OSD: provide newer command descs with module/perm/availDan Mick2013-07-261-18/+26
| | | | | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * ceph.in: clean up help, fix partial matching on all helpDan Mick2013-07-261-39/+18
| | | | | | | | | | | | Remove --help-all; too much effort for low benefit Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * ceph.in: admin_socket() now validates command and passes formatDan Mick2013-07-261-18/+52
| | | | | | | | Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * ceph_argparse.py, ceph.in: validate_command: stop handling formatDan Mick2013-07-262-8/+7
| | | | | | | | | | | | | | | | We were passing the entire parsed_args Namespace just to look at and tack on 'format', and that's kinda silly; do it in the callers instead. Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * In general, flush in caller of dump worker rather than workerDan Mick2013-07-267-19/+15
| | | | | | | | | | | | | | This allows easier refactoring of workers (no dual flushes when code changes). Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * Formatter, admin_socket: make default formatter be json-prettyDan Mick2013-07-253-16/+11
| | | | | | | | | | | | | | | | If not given, default to json-pretty; if given but not equal to one of the formatter choices, return NULL as before. Remove defaulting code in admin_socket.cc in favor of this. Signed-off-by: Dan Mick <dan.mick@inktank.com>
| * AdminSocket users: use generic formattingDan Mick2013-07-2517-247/+267
| | | | | | | | | | | | | | | | | | All call() routines get a format parameter; all places where JSONFormatter was created get a new_formatter() instead. 'plain' formatting is unsupported, and help is forced to be 'json-pretty' as it was. Signed-off-by: Dan Mick <dan.mick@inktank.com>
* | mon/PGMonitor: reset in-core PGMap if on-disk format changesSage Weil2013-07-264-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We might have a sequence like: - start mon, load pgmap 100 - sync - including a format upgrade at say v 150 - refresh - see format_version==1, and try read pgmap:101 as new format This simply clears our in-memory state if we see that the format has changed. That will make update_from_paxos reload the latest and prevent it from walking through the old and useless inc updates. Note: this does not affect the auth monitor because we unconditionally load the latest map in update_from_paxos on upgrade. Also, the upgrade there wasn't a format change--just a translation of cap strings from the old to new style. Fixes: #5764 Signed-off-by: Sage Weil <sage@inktank.com> Reviewed-by: Greg Farnum <greg@inktank.com>
* | Merge pull request #470 from dalgaaf/wip-da-CID-3.v2Sage Weil2013-07-265-15/+12
|\ \ | | | | | | | | | | | | Fix several CID issues - v2 Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
| * | rgw/rgw_metadata.cc: delete md_log (RGWMetadataLog) in destructorDanny Al-Gaaf2013-07-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Call delete on md_log in the destructor. CID 1054826 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK) 1. alloc_new: Allocating memory by calling "new RGWMetadataLog(_cct, _store)". 2. var_assign: Assigning: "this->md_log" = "new RGWMetadataLog(_cct, _store)". 3. ctor_dtor_leak: The constructor allocates field "md_log" of "RGWMetadataManager" but the destructor and whatever functions it calls do not free it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | rgw/rgw_rest_log.cc: free 'handle' to prevent memory leakDanny Al-Gaaf2013-07-261-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Call complete_list_entries() at end of RGWOp_MDLog_List::execute() to free the 'handle'. CID 1054834 (#1-2 of 2): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "handle" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test_cls_log.cc: fix resource leak, delete 'rop'Danny Al-Gaaf2013-07-261-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes for: CID 1054838 (#14 of 14): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "rop" going out of scope leaks the storage it points to. CID 1054836 (#5 of 5): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "rop" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test_cls_log.cc: remove empty linesDanny Al-Gaaf2013-07-261-14/+0
| | | | | | | | | | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test_cls_statelog.cc: fix memory leak, delete 'rop'Danny Al-Gaaf2013-07-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | CID 1054840 (#3 of 3): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "rop" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test_cls_version.cc: close some memory leaksDanny Al-Gaaf2013-07-261-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Close some memory leaks caused by calling new() without freeing the memory already assigned to 'rop'. CID 1054848 (#1-6 of 6): Resource leak (RESOURCE_LEAK) overwrite_var: Overwriting "rop" in "rop = new_rop()" leaks the storage that "rop" points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | Merge pull request #467 from dalgaaf/wip-da-next-SCA-cppcheck-1Sage Weil2013-07-264-15/+7
|\ \ \ | |/ / |/| | | | | | | | Fix typical smaller issues from SCA Reviewed-by: Sage Weil <sage@inktank.com>
| * | rgw/rgw_metadata.h: init prefix in initialization listDanny Al-Gaaf2013-07-251-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | For performance reasons: init 'prefix' with META_LOG_OBJ_PREFIX in the initialization list of RGWMetadataLog instead of assigning the value in the constructor body. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test_rgw_admin_log.cc: remove unused variable 'creds'Danny Al-Gaaf2013-07-251-2/+0
| | | | | | | | | | | | Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
View Lorry Controller Status