diff options
author | Sviatoslav Sydorenko <wk@sydorenko.org.ua> | 2018-09-09 22:17:24 +0200 |
---|---|---|
committer | Sviatoslav Sydorenko <wk@sydorenko.org.ua> | 2018-09-09 22:17:47 +0200 |
commit | ed7ea2d3a1ec1ee05452b86305ac8d0894081571 (patch) | |
tree | 434f3f03a59143b273df5ed9b8120736f272e9e3 | |
parent | 1c6dad3e1a5ba9fac97213a4ac9996762038149d (diff) | |
download | cherrypy-git-ed7ea2d3a1ec1ee05452b86305ac8d0894081571.tar.gz |
Move exception trapping to the right place
-rwxr-xr-x | cherrypy/test/test_session.py | 29 |
1 files changed, 14 insertions, 15 deletions
diff --git a/cherrypy/test/test_session.py b/cherrypy/test/test_session.py index e8a4bdca..45484d74 100755 --- a/cherrypy/test/test_session.py +++ b/cherrypy/test/test_session.py @@ -401,19 +401,12 @@ class SessionTest(helper.CPWebCase): @pytest.fixture(scope='session') -def memcached_instance(request): +def memcached_instance(request, watcher_getter): """ Start up an instance of memcached. """ pytest.importorskip('memcache') - try: - watcher_getter = request.getfixturevalue('watcher_getter') - except AssertionError as err: - if str(err) != 'You have to install memcached executable.': - raise - pytest.skip('memcached not available') - port = portend.find_available_local_port() def is_occupied(): @@ -423,13 +416,19 @@ def memcached_instance(request): return True return False - proc = watcher_getter( - name='memcached', - arguments=['-p', str(port)], - checker=is_occupied, - request=request, - ) - return locals() + try: + proc = watcher_getter( + name='memcached', + arguments=['-p', str(port)], + checker=is_occupied, + request=request, + ) + except AssertionError as err: + if str(err) != 'You have to install memcached executable.': + raise + pytest.skip('memcached not available') + else: + return locals() @pytest.fixture |