From 4a70a4afc5fec1684a007a77f8b3f0e67692ef77 Mon Sep 17 00:00:00 2001 From: "Jason R. Coombs" Date: Sat, 30 Apr 2016 07:56:43 -0400 Subject: Replace references to bitbucket tickets with references to github tickets. Ref #1410. --- cherrypy/__init__.py | 2 +- cherrypy/_cpdispatch.py | 4 ++-- cherrypy/_cpreqbody.py | 2 +- cherrypy/_cptools.py | 4 ++-- cherrypy/lib/caching.py | 2 +- cherrypy/lib/httputil.py | 2 +- cherrypy/lib/sessions.py | 2 +- cherrypy/process/wspbus.py | 6 +++--- cherrypy/test/test_config_server.py | 2 +- cherrypy/test/test_conn.py | 2 +- cherrypy/test/test_core.py | 4 ++-- cherrypy/test/test_http.py | 4 ++-- cherrypy/test/test_mime.py | 2 +- cherrypy/test/test_objectmapping.py | 4 ++-- cherrypy/test/test_proxy.py | 2 +- cherrypy/test/test_request_obj.py | 10 +++++----- cherrypy/test/test_xmlrpc.py | 2 +- cherrypy/wsgiserver/wsgiserver2.py | 18 +++++++++--------- cherrypy/wsgiserver/wsgiserver3.py | 18 +++++++++--------- 19 files changed, 46 insertions(+), 46 deletions(-) diff --git a/cherrypy/__init__.py b/cherrypy/__init__.py index 6e2f9bdb..2c2443f0 100644 --- a/cherrypy/__init__.py +++ b/cherrypy/__init__.py @@ -318,7 +318,7 @@ class _GlobalLogManager(_cplogging.LogManager): """Log the given message to the app.log or global log as appropriate. """ # Do NOT use try/except here. See - # https://bitbucket.org/cherrypy/cherrypy/issue/945 + # https://github.com/cherrypy/cherrypy/issues/945 if hasattr(request, 'app') and hasattr(request.app, 'log'): log = request.app.log else: diff --git a/cherrypy/_cpdispatch.py b/cherrypy/_cpdispatch.py index 710bb3fd..2cb03c7e 100644 --- a/cherrypy/_cpdispatch.py +++ b/cherrypy/_cpdispatch.py @@ -422,7 +422,7 @@ class Dispatcher(object): object_trail.insert( i + 1, ["default", defhandler, conf, segleft]) request.config = set_conf() - # See https://bitbucket.org/cherrypy/cherrypy/issue/613 + # See https://github.com/cherrypy/cherrypy/issues/613 request.is_index = path.endswith("/") return defhandler, fullpath[fullpath_len - segleft:-1] @@ -675,7 +675,7 @@ def VirtualHost(next_dispatcher=Dispatcher(), use_x_forwarded_host=True, result = next_dispatcher(path_info) # Touch up staticdir config. See - # https://bitbucket.org/cherrypy/cherrypy/issue/614. + # https://github.com/cherrypy/cherrypy/issues/614. section = request.config.get('tools.staticdir.section') if section: section = section[len(prefix):] diff --git a/cherrypy/_cpreqbody.py b/cherrypy/_cpreqbody.py index d2dbbc92..13a8adb7 100644 --- a/cherrypy/_cpreqbody.py +++ b/cherrypy/_cpreqbody.py @@ -940,7 +940,7 @@ class RequestBody(Entity): # Don't parse the request body at all if the client didn't provide # a Content-Type header. See - # https://bitbucket.org/cherrypy/cherrypy/issue/790 + # https://github.com/cherrypy/cherrypy/issues/790 default_content_type = '' """This defines a default ``Content-Type`` to use if no Content-Type header is given. The empty string is used for RequestBody, which results in the diff --git a/cherrypy/_cptools.py b/cherrypy/_cptools.py index 06a56e87..af76ae06 100644 --- a/cherrypy/_cptools.py +++ b/cherrypy/_cptools.py @@ -271,7 +271,7 @@ class SessionTool(Tool): body. This is off by default for safety reasons; for example, a large upload would block the session, denying an AJAX progress meter - (`issue `_). + (`issue `_). When 'explicit' (or any other value), you need to call cherrypy.session.acquire_lock() yourself before using @@ -376,7 +376,7 @@ class XMLRPCController(object): body = subhandler(*(vpath + rpcparams), **params) else: - # https://bitbucket.org/cherrypy/cherrypy/issue/533 + # https://github.com/cherrypy/cherrypy/issues/533 # if a method is not found, an xmlrpclib.Fault should be returned # raising an exception here will do that; see # cherrypy.lib.xmlrpcutil.on_error diff --git a/cherrypy/lib/caching.py b/cherrypy/lib/caching.py index fab6b569..375d5f0e 100644 --- a/cherrypy/lib/caching.py +++ b/cherrypy/lib/caching.py @@ -353,7 +353,7 @@ def get(invalid_methods=("POST", "PUT", "DELETE"), debug=False, **kwargs): return False # Copy the response headers. See - # https://bitbucket.org/cherrypy/cherrypy/issue/721. + # https://github.com/cherrypy/cherrypy/issues/721. response.headers = rh = httputil.HeaderMap() for k in h: dict.__setitem__(rh, k, dict.__getitem__(h, k)) diff --git a/cherrypy/lib/httputil.py b/cherrypy/lib/httputil.py index 69a18d45..f249e6dd 100644 --- a/cherrypy/lib/httputil.py +++ b/cherrypy/lib/httputil.py @@ -13,7 +13,7 @@ from cherrypy._cpcompat import basestring, bytestr, iteritems, nativestr from cherrypy._cpcompat import reversed, sorted, unicodestr, unquote_qs response_codes = BaseHTTPRequestHandler.responses.copy() -# From https://bitbucket.org/cherrypy/cherrypy/issue/361 +# From https://github.com/cherrypy/cherrypy/issues/361 response_codes[500] = ('Internal Server Error', 'The server encountered an unexpected condition ' 'which prevented it from fulfilling the request.') diff --git a/cherrypy/lib/sessions.py b/cherrypy/lib/sessions.py index 37556363..e9605cb8 100644 --- a/cherrypy/lib/sessions.py +++ b/cherrypy/lib/sessions.py @@ -182,7 +182,7 @@ class Session(object): cherrypy.log('Expired or malicious session %r; ' 'making a new one' % id, 'TOOLS.SESSIONS') # Expired or malicious session. Make a new one. - # See https://bitbucket.org/cherrypy/cherrypy/issue/709. + # See https://github.com/cherrypy/cherrypy/issues/709. self.id = None self.missing = True self._regenerate() diff --git a/cherrypy/process/wspbus.py b/cherrypy/process/wspbus.py index c9de3511..9c9a2739 100644 --- a/cherrypy/process/wspbus.py +++ b/cherrypy/process/wspbus.py @@ -85,7 +85,7 @@ class ChannelFailures(Exception): def __init__(self, *args, **kwargs): # Don't use 'super' here; Exceptions are old-style in Py2.4 - # See https://bitbucket.org/cherrypy/cherrypy/issue/959 + # See https://github.com/cherrypy/cherrypy/issues/959 Exception.__init__(self, *args, **kwargs) self._exceptions = list() @@ -317,10 +317,10 @@ class Bus(object): raise # Waiting for ALL child threads to finish is necessary on OS X. - # See https://bitbucket.org/cherrypy/cherrypy/issue/581. + # See https://github.com/cherrypy/cherrypy/issues/581. # It's also good to let them all shut down before allowing # the main thread to call atexit handlers. - # See https://bitbucket.org/cherrypy/cherrypy/issue/751. + # See https://github.com/cherrypy/cherrypy/issues/751. self.log("Waiting for child threads to terminate...") for t in threading.enumerate(): # Validate the we're not trying to join the MainThread diff --git a/cherrypy/test/test_config_server.py b/cherrypy/test/test_config_server.py index 40504d8f..f4f574de 100644 --- a/cherrypy/test/test_config_server.py +++ b/cherrypy/test/test_config_server.py @@ -93,7 +93,7 @@ class ServerConfigTests(helper.CPWebCase): self.getPage("/", headers=[('From', "x" * 500)]) self.assertStatus(413) - # Test for https://bitbucket.org/cherrypy/cherrypy/issue/421 + # Test for https://github.com/cherrypy/cherrypy/issues/421 # (Incorrect border condition in readline of SizeCheckWrapper). # This hangs in rev 891 and earlier. lines256 = "x" * 248 diff --git a/cherrypy/test/test_conn.py b/cherrypy/test/test_conn.py index 6577e03a..3e0cbc16 100644 --- a/cherrypy/test/test_conn.py +++ b/cherrypy/test/test_conn.py @@ -205,7 +205,7 @@ class ConnectionCloseTests(helper.CPWebCase): self.assertRaises(NotConnected, self.getPage, "/") # Try HEAD. See - # https://bitbucket.org/cherrypy/cherrypy/issue/864. + # https://github.com/cherrypy/cherrypy/issues/864. self.getPage("/stream", method='HEAD') self.assertStatus('200 OK') self.assertBody('') diff --git a/cherrypy/test/test_core.py b/cherrypy/test/test_core.py index 4ebc170a..16a0219d 100644 --- a/cherrypy/test/test_core.py +++ b/cherrypy/test/test_core.py @@ -403,7 +403,7 @@ class CoreRequestHandlingTest(helper.CPWebCase): self.assertStatus(('302 Found', '303 See Other')) # check injection protection - # See https://bitbucket.org/cherrypy/cherrypy/issue/1003 + # See https://github.com/cherrypy/cherrypy/issues/1003 self.getPage( "/redirect/custom?" "code=303&url=/foobar/%0d%0aSet-Cookie:%20somecookie=someval") @@ -551,7 +551,7 @@ class CoreRequestHandlingTest(helper.CPWebCase): def skip_if_bad_cookies(self): """ cookies module fails to reject invalid cookies - https://bitbucket.org/cherrypy/cherrypy/issues/1405 + https://github.com/cherrypy/cherrypy/issues/1405 """ cookies = sys.modules.get('http.cookies') _is_legal_key = getattr(cookies, '_is_legal_key', lambda x: False) diff --git a/cherrypy/test/test_http.py b/cherrypy/test/test_http.py index 0df589fa..46ae226c 100644 --- a/cherrypy/test/test_http.py +++ b/cherrypy/test/test_http.py @@ -150,7 +150,7 @@ class HTTPTests(helper.CPWebCase): def test_post_filename_with_commas(self): '''Testing that we can handle filenames with commas. This was reported as a bug in: - https://bitbucket.org/cherrypy/cherrypy/issue/1146/''' + https://github.com/cherrypy/cherrypy/issues/1146/''' # We'll upload a bunch of files with differing names. for fname in ['boop.csv', 'foo, bar.csv', 'bar, xxxx.csv', 'file"name.csv']: files = [('myfile', fname, 'yunyeenyunyue')] @@ -200,7 +200,7 @@ class HTTPTests(helper.CPWebCase): c = self.make_connection() c.putrequest('GET', '/') c.putheader('Content-Type', 'text/plain') - # See https://bitbucket.org/cherrypy/cherrypy/issue/941 + # See https://github.com/cherrypy/cherrypy/issues/941 c._output(ntob('Re, 1.2.3.4#015#012')) c.endheaders() diff --git a/cherrypy/test/test_mime.py b/cherrypy/test/test_mime.py index f5f2b9fb..ca2f9c63 100644 --- a/cherrypy/test/test_mime.py +++ b/cherrypy/test/test_mime.py @@ -74,7 +74,7 @@ This is the HTML version '--X', # Test a param with more than one value. # See - # https://bitbucket.org/cherrypy/cherrypy/issue/1028 + # https://github.com/cherrypy/cherrypy/issues/1028 'Content-Disposition: form-data; name="baz"', '', '111', diff --git a/cherrypy/test/test_objectmapping.py b/cherrypy/test/test_objectmapping.py index e80a7a71..a24e84e1 100644 --- a/cherrypy/test/test_objectmapping.py +++ b/cherrypy/test/test_objectmapping.py @@ -281,7 +281,7 @@ class ObjectMappingTest(helper.CPWebCase): # Make sure /foobar maps to Root.foobar and not to the app # mounted at /foo. See - # https://bitbucket.org/cherrypy/cherrypy/issue/573 + # https://github.com/cherrypy/cherrypy/issues/573 self.getPage("/foobar") self.assertBody("bar") @@ -332,7 +332,7 @@ class ObjectMappingTest(helper.CPWebCase): self.assertBody("default for dir1, param is:('dir2', '5', '3', 'sir')") # test that extra positional args raises an 404 Not Found - # See https://bitbucket.org/cherrypy/cherrypy/issue/733. + # See https://github.com/cherrypy/cherrypy/issues/733. self.getPage("/dir1/dir2/script_name/extra/stuff") self.assertStatus(404) diff --git a/cherrypy/test/test_proxy.py b/cherrypy/test/test_proxy.py index 821a4e52..bdc5eada 100644 --- a/cherrypy/test/test_proxy.py +++ b/cherrypy/test/test_proxy.py @@ -131,7 +131,7 @@ class ProxyTest(helper.CPWebCase): self.assertBody(expected) # Test trailing slash (see - # https://bitbucket.org/cherrypy/cherrypy/issue/562). + # https://github.com/cherrypy/cherrypy/issues/562). self.getPage("/xhost/", headers=[('X-Host', 'www.example.test')]) self.assertHeader('Location', "%s://www.example.test/xhost" % self.scheme) diff --git a/cherrypy/test/test_request_obj.py b/cherrypy/test/test_request_obj.py index a74ddddf..58736b54 100644 --- a/cherrypy/test/test_request_obj.py +++ b/cherrypy/test/test_request_obj.py @@ -184,7 +184,7 @@ class RequestObjectTests(helper.CPWebCase): return cherrypy.request.headers[headername] def doubledheaders(self): - # From https://bitbucket.org/cherrypy/cherrypy/issue/165: + # From https://github.com/cherrypy/cherrypy/issues/165: # "header field names should not be case sensitive sayes the # rfc. if i set a headerfield in complete lowercase i end up # with two header fields, one in lowercase, the other in @@ -643,7 +643,7 @@ class RequestObjectTests(helper.CPWebCase): "en;q=0.7") # Test malformed header parsing. See - # https://bitbucket.org/cherrypy/cherrypy/issue/763. + # https://github.com/cherrypy/cherrypy/issues/763. self.getPage("/headerelements/get_elements?headername=Content-Type", # Note the illegal trailing ";" headers=[('Content-Type', 'text/html; charset=utf-8;')]) @@ -652,7 +652,7 @@ class RequestObjectTests(helper.CPWebCase): def test_repeated_headers(self): # Test that two request headers are collapsed into one. - # See https://bitbucket.org/cherrypy/cherrypy/issue/542. + # See https://github.com/cherrypy/cherrypy/issues/542. self.getPage("/headers/Accept-Charset", headers=[("Accept-Charset", "iso-8859-5"), ("Accept-Charset", "unicode-1-1;q=0.8")]) @@ -738,7 +738,7 @@ class RequestObjectTests(helper.CPWebCase): self.assertBody(b) # Request a PUT method with a file body but no Content-Type. - # See https://bitbucket.org/cherrypy/cherrypy/issue/790. + # See https://github.com/cherrypy/cherrypy/issues/790. b = ntob("one thing on top of another") self.persistent = True try: @@ -757,7 +757,7 @@ class RequestObjectTests(helper.CPWebCase): self.persistent = False # Request a PUT method with no body whatsoever (not an empty one). - # See https://bitbucket.org/cherrypy/cherrypy/issue/650. + # See https://github.com/cherrypy/cherrypy/issues/650. # Provide a C-T or webtest will provide one (and a C-L) for us. h = [("Content-Type", "text/plain")] self.getPage("/method/reachable", headers=h, method="PUT") diff --git a/cherrypy/test/test_xmlrpc.py b/cherrypy/test/test_xmlrpc.py index 8f091ff1..4beed0a3 100644 --- a/cherrypy/test/test_xmlrpc.py +++ b/cherrypy/test/test_xmlrpc.py @@ -163,7 +163,7 @@ class XmlRpcTest(helper.CPWebCase): else: self.fail("Expected xmlrpclib.Fault") - # https://bitbucket.org/cherrypy/cherrypy/issue/533 + # https://github.com/cherrypy/cherrypy/issues/533 # if a method is not found, an xmlrpclib.Fault should be raised try: proxy.non_method() diff --git a/cherrypy/wsgiserver/wsgiserver2.py b/cherrypy/wsgiserver/wsgiserver2.py index 9abf676f..175affc1 100644 --- a/cherrypy/wsgiserver/wsgiserver2.py +++ b/cherrypy/wsgiserver/wsgiserver2.py @@ -297,7 +297,7 @@ class SizeCheckWrapper(object): self.bytes_read += len(data) self._check_length() res.append(data) - # See https://bitbucket.org/cherrypy/cherrypy/issue/421 + # See https://github.com/cherrypy/cherrypy/issues/421 if len(data) < 256 or data[-1:] == LF: return EMPTY.join(res) @@ -797,7 +797,7 @@ class HTTPRequest(object): if self.inheaders.get("Expect", "") == "100-continue": # Don't use simple_response here, because it emits headers # we don't want. See - # https://bitbucket.org/cherrypy/cherrypy/issue/951 + # https://github.com/cherrypy/cherrypy/issues/951 msg = self.server.protocol + " 100 Continue\r\n\r\n" try: self.conn.wfile.sendall(msg) @@ -1363,7 +1363,7 @@ class HTTPConnection(object): # Don't error if we're between requests; only error # if 1) no request has been started at all, or 2) we're # in the middle of a request. - # See https://bitbucket.org/cherrypy/cherrypy/issue/853 + # See https://github.com/cherrypy/cherrypy/issues/853 if (not request_seen) or (req and req.started_request): # Don't bother writing the 408 if the response # has already started being written. @@ -1656,7 +1656,7 @@ class ThreadPool(object): except (AssertionError, # Ignore repeated Ctrl-C. # See - # https://bitbucket.org/cherrypy/cherrypy/issue/691. + # https://github.com/cherrypy/cherrypy/issues/691. KeyboardInterrupt): pass @@ -1981,7 +1981,7 @@ class HTTPServer(object): # If listening on the IPV6 any address ('::' = IN6ADDR_ANY), # activate dual-stack. See - # https://bitbucket.org/cherrypy/cherrypy/issue/871. + # https://github.com/cherrypy/cherrypy/issues/871. if (hasattr(socket, 'AF_INET6') and family == socket.AF_INET6 and self.bind_addr[0] in ('::', '::0', '::0.0.0.0')): try: @@ -2075,15 +2075,15 @@ class HTTPServer(object): # the call, and I *think* I'm reading it right that Python # will then go ahead and poll for and handle the signal # elsewhere. See - # https://bitbucket.org/cherrypy/cherrypy/issue/707. + # https://github.com/cherrypy/cherrypy/issues/707. return if x.args[0] in socket_errors_nonblocking: # Just try again. See - # https://bitbucket.org/cherrypy/cherrypy/issue/479. + # https://github.com/cherrypy/cherrypy/issues/479. return if x.args[0] in socket_errors_to_ignore: # Our socket was closed. - # See https://bitbucket.org/cherrypy/cherrypy/issue/686. + # See https://github.com/cherrypy/cherrypy/issues/686. return raise @@ -2116,7 +2116,7 @@ class HTTPServer(object): if x.args[0] not in socket_errors_to_ignore: # Changed to use error code and not message # See - # https://bitbucket.org/cherrypy/cherrypy/issue/860. + # https://github.com/cherrypy/cherrypy/issues/860. raise else: # Note that we're explicitly NOT using AI_PASSIVE, diff --git a/cherrypy/wsgiserver/wsgiserver3.py b/cherrypy/wsgiserver/wsgiserver3.py index 84df3a34..319a8895 100644 --- a/cherrypy/wsgiserver/wsgiserver3.py +++ b/cherrypy/wsgiserver/wsgiserver3.py @@ -282,7 +282,7 @@ class SizeCheckWrapper(object): self.bytes_read += len(data) self._check_length() res.append(data) - # See https://bitbucket.org/cherrypy/cherrypy/issue/421 + # See https://github.com/cherrypy/cherrypy/issues/421 if len(data) < 256 or data[-1:] == LF: return EMPTY.join(res) @@ -785,7 +785,7 @@ class HTTPRequest(object): if self.inheaders.get(b"Expect", b"") == b"100-continue": # Don't use simple_response here, because it emits headers # we don't want. See - # https://bitbucket.org/cherrypy/cherrypy/issue/951 + # https://github.com/cherrypy/cherrypy/issues/951 msg = self.server.protocol.encode( 'ascii') + b" 100 Continue\r\n\r\n" try: @@ -1089,7 +1089,7 @@ class HTTPConnection(object): # Don't error if we're between requests; only error # if 1) no request has been started at all, or 2) we're # in the middle of a request. - # See https://bitbucket.org/cherrypy/cherrypy/issue/853 + # See https://github.com/cherrypy/cherrypy/issues/853 if (not request_seen) or (req and req.started_request): # Don't bother writing the 408 if the response # has already started being written. @@ -1378,7 +1378,7 @@ class ThreadPool(object): except (AssertionError, # Ignore repeated Ctrl-C. # See - # https://bitbucket.org/cherrypy/cherrypy/issue/691. + # https://github.com/cherrypy/cherrypy/issues/691. KeyboardInterrupt): pass @@ -1703,7 +1703,7 @@ class HTTPServer(object): # If listening on the IPV6 any address ('::' = IN6ADDR_ANY), # activate dual-stack. See - # https://bitbucket.org/cherrypy/cherrypy/issue/871. + # https://github.com/cherrypy/cherrypy/issues/871. if (hasattr(socket, 'AF_INET6') and family == socket.AF_INET6 and self.bind_addr[0] in ('::', '::0', '::0.0.0.0')): try: @@ -1797,15 +1797,15 @@ class HTTPServer(object): # the call, and I *think* I'm reading it right that Python # will then go ahead and poll for and handle the signal # elsewhere. See - # https://bitbucket.org/cherrypy/cherrypy/issue/707. + # https://github.com/cherrypy/cherrypy/issues/707. return if x.args[0] in socket_errors_nonblocking: # Just try again. See - # https://bitbucket.org/cherrypy/cherrypy/issue/479. + # https://github.com/cherrypy/cherrypy/issues/479. return if x.args[0] in socket_errors_to_ignore: # Our socket was closed. - # See https://bitbucket.org/cherrypy/cherrypy/issue/686. + # See https://github.com/cherrypy/cherrypy/issues/686. return raise @@ -1838,7 +1838,7 @@ class HTTPServer(object): if x.args[0] not in socket_errors_to_ignore: # Changed to use error code and not message # See - # https://bitbucket.org/cherrypy/cherrypy/issue/860. + # https://github.com/cherrypy/cherrypy/issues/860. raise else: # Note that we're explicitly NOT using AI_PASSIVE, -- cgit v1.2.1