diff options
| author | Gabor Horvath <xazax.hun@gmail.com> | 2016-03-30 11:22:14 +0000 |
|---|---|---|
| committer | Gabor Horvath <xazax.hun@gmail.com> | 2016-03-30 11:22:14 +0000 |
| commit | 222b56d7670c4002fa947ad463bbb0eb036b8d8d (patch) | |
| tree | b9cc389b1ab68275738efed791e0d14c34eb06f3 /docs | |
| parent | 9ee58a4a37a1c06060c90b68ac6bc3f49ca99dd2 (diff) | |
| download | clang-222b56d7670c4002fa947ad463bbb0eb036b8d8d.tar.gz | |
[ASTMatchers] Existing matcher hasAnyArgument fixed
Summary: A checker (will be uploaded after this patch) needs to check implicit casts. The checker needs matcher hasAnyArgument but it ignores implicit casts and parenthesized expressions which disables checking of implicit casts for arguments in the checker. However the documentation of the matcher contains a FIXME that this should be removed once separate matchers for ignoring implicit casts and parenthesized expressions are ready. Since these matchers were already there the fix could be executed. Only one Clang checker was affected which was also fixed (ignoreParenImpCasts added) and is separately uploaded. Third party checkers (not in the Clang repository) may be affected by this fix so the fix must be emphasized in the release notes.
Reviewers: klimek, sbenza, alexfh
Subscribers: alexfh, klimek, xazax.hun, cfe-commits
Differential Revision: http://reviews.llvm.org/D18243
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@264855 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/LibASTMatchersReference.html | 10 | ||||
| -rw-r--r-- | docs/ReleaseNotes.rst | 6 |
2 files changed, 6 insertions, 10 deletions
diff --git a/docs/LibASTMatchersReference.html b/docs/LibASTMatchersReference.html index 58ab6d1285..aaddb5b840 100644 --- a/docs/LibASTMatchersReference.html +++ b/docs/LibASTMatchersReference.html @@ -3636,11 +3636,6 @@ callExpr(hasAnyArgument(declRefExpr())) matches x(1, y, 42) with hasAnyArgument(...) matching y - -FIXME: Currently this will ignore parentheses and implicit casts on -the argument before applying the inner matcher. We'll want to remove -this to allow for greater control by the user once ignoreImplicit() -has been implemented. </pre></td></tr> @@ -3907,11 +3902,6 @@ callExpr(hasAnyArgument(declRefExpr())) matches x(1, y, 42) with hasAnyArgument(...) matching y - -FIXME: Currently this will ignore parentheses and implicit casts on -the argument before applying the inner matcher. We'll want to remove -this to allow for greater control by the user once ignoreImplicit() -has been implemented. </pre></td></tr> diff --git a/docs/ReleaseNotes.rst b/docs/ReleaseNotes.rst index 922c37e6f0..942e12eed1 100644 --- a/docs/ReleaseNotes.rst +++ b/docs/ReleaseNotes.rst @@ -120,6 +120,12 @@ this section should help get you past the largest hurdles of upgrading. AST Matchers ------------ +- hasAnyArgument: Matcher no longer ignores parentheses and implicit casts on + the argument before applying the inner matcher. The fix was done to allow for + greater control by the user. In all existing checkers that use this matcher + all instances of code ``hasAnyArgument(<inner matcher>)`` must be changed to + ``hasAnyArgument(ignoringParenImpCasts(<inner matcher>))``. + ... libclang |