diff options
| -rw-r--r-- | docs/ReleaseNotes.rst | 4 | ||||
| -rw-r--r-- | test/Sema/sign-compare-enum.c | 24 |
2 files changed, 28 insertions, 0 deletions
diff --git a/docs/ReleaseNotes.rst b/docs/ReleaseNotes.rst index 698672e479..997c6d3fcd 100644 --- a/docs/ReleaseNotes.rst +++ b/docs/ReleaseNotes.rst @@ -82,6 +82,10 @@ Improvements to Clang's diagnostics tautological comparisons between integer variable of the type ``T`` and the largest/smallest possible integer constant of that same type. +- For C code, ``-Wsign-compare``, ``-Wtautological-constant-compare`` and + ``-Wtautological-constant-out-of-range-compare`` were adjusted to use the + underlying datatype of ``enum``. + - ``-Wnull-pointer-arithmetic`` now warns about performing pointer arithmetic on a null pointer. Such pointer arithmetic has an undefined behavior if the offset is nonzero. It also now warns about arithmetic on a null pointer diff --git a/test/Sema/sign-compare-enum.c b/test/Sema/sign-compare-enum.c new file mode 100644 index 0000000000..8661bd502f --- /dev/null +++ b/test/Sema/sign-compare-enum.c @@ -0,0 +1,24 @@ +// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -DUNSIGNED -verify -Wsign-compare %s +// RUN: %clang_cc1 -triple=x86_64-pc-win32 -fsyntax-only -DSIGNED -verify -Wsign-compare %s +// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -DUNSIGNED -DSILENCE -verify %s +// RUN: %clang_cc1 -triple=x86_64-pc-win32 -fsyntax-only -DSIGNED -DSILENCE -verify %s + +int main() { + enum A { A_a = 0, A_b = 1 }; + static const int message[] = {0, 1}; + enum A a; + + if (a < 2) + return 0; + +#if defined(SIGNED) && !defined(SILENCE) + if (a < sizeof(message)/sizeof(message[0])) // expected-warning {{comparison of integers of different signs: 'enum A' and 'unsigned long long'}} + return 0; +#else + // expected-no-diagnostics + if (a < 2U) + return 0; + if (a < sizeof(message)/sizeof(message[0])) + return 0; +#endif +} |