diff options
| author | Andrew John Hughes <gnu_andrew@member.fsf.org> | 2012-10-30 19:55:39 +0000 |
|---|---|---|
| committer | Andrew John Hughes <gnu_andrew@member.fsf.org> | 2012-10-30 19:55:39 +0000 |
| commit | 2f2203bd748429389d7a06e3f278b2bef36718bb (patch) | |
| tree | e0df2d13a7df85871571f428e837c36682c6d560 | |
| parent | fffc5f315111381d4bfe7678b4aa8fe37c2f6b21 (diff) | |
| download | classpath-2f2203bd748429389d7a06e3f278b2bef36718bb.tar.gz | |
PR55140: Addition of exception to codePointBefore breaks OpenJDK GenerateBreakIteratorData tool
2012-10-30 Andrew John Hughes <gnu_andrew@member.fsf.org>
PR classpath/55140
* NEWS: List fix.
* java/lang/String.java:
(codePointBefore(int)): Fix index check to match spec.
Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | NEWS | 1 | ||||
| -rw-r--r-- | java/lang/String.java | 4 |
3 files changed, 10 insertions, 2 deletions
@@ -1,3 +1,10 @@ +2012-10-30 Andrew John Hughes <gnu_andrew@member.fsf.org> + + PR classpath/55140 + * NEWS: List fix. + * java/lang/String.java: + (codePointBefore(int)): Fix index check to match spec. + 2012-10-16 Ivan Maidanski <ivmai@mail.ru> * java/util/Collections.java: @@ -19,6 +19,7 @@ New in release 0.99.1 (XXX XX, 2012) - PR42551: Avoid overwriting length of message when computing length representation. - PR44208: Ensure a handle for the enum is registered before its constant. - PR41689: javax.security.sasl.CREDIENTIALS field is missing + - PR55140: Addition of exception to codePointBefore breaks OpenJDK GenerateBreakIteratorData tool New in release 0.99 (Feb 15, 2012) diff --git a/java/lang/String.java b/java/lang/String.java index eb713ce2a..27294cdd4 100644 --- a/java/lang/String.java +++ b/java/lang/String.java @@ -718,13 +718,13 @@ public final class String * <code>index-2</code> to see if they form a supplementary code point. * @param index the index just past the codepoint to get, starting at 0 * @return the codepoint at the specified index - * @throws IndexOutOfBoundsException if index is negative or >= length() + * @throws IndexOutOfBoundsException if index is less than 1 or > length() * (while unspecified, this is a StringIndexOutOfBoundsException) * @since 1.5 */ public synchronized int codePointBefore(int index) { - if (index < 0 || index >= count) + if (index < 1 || index > count) throw new StringIndexOutOfBoundsException(index); // Use the CharSequence overload as we get better range checking // this way. |