diff options
| author | Andrew John Hughes <gnu_andrew@member.fsf.org> | 2008-09-01 14:54:32 +0000 |
|---|---|---|
| committer | Andrew John Hughes <gnu_andrew@member.fsf.org> | 2008-09-01 14:54:32 +0000 |
| commit | b42079a4f1e4738c5ba9d30b4b9afb0f4bd3f2e3 (patch) | |
| tree | 0094f22f24089f7a2ca609fd1063f7a6adb34044 /gnu | |
| parent | e38de7943810d933e6ea69b8a8a26f893399aa6b (diff) | |
| download | classpath-b42079a4f1e4738c5ba9d30b4b9afb0f4bd3f2e3.tar.gz | |
Fix FindBugs issues.
2008-09-01 Andrew John Hughes <gnu_andrew@member.fsf.org>
* gnu/java/util/regex/RETokenStart.java:
(getMaximumLength()): Add Override annotation.
(matchThis(CharIndexed, REMatch)): Likewise.
(returnsFixedLengthMatches()): Renamed from
returnsFixedLengthmatches and added Override
annotation.
(findFixedLengthMatches(CharIndexed,REMatch,int)):
Add Override annotation.
(dump(CPStringBuilder)): Likewise.
* gnu/javax/print/ipp/IppRequest.java:
(RequestWriter.writeOperationAttributes(AttributeSet)):
Throw exception, don't just create and drop it.
* javax/management/MBeanServerPermission.java:
(MBeanServerPermissionCollection.add(Permission)): Compare
against individual Strings not the entire array, and
store the result of replace.
* javax/swing/text/html/StyleSheet.java:
(setBaseFontSize(size)): Store result of trim().
Diffstat (limited to 'gnu')
| -rw-r--r-- | gnu/java/util/regex/RETokenStart.java | 11 | ||||
| -rw-r--r-- | gnu/javax/print/ipp/IppRequest.java | 2 |
2 files changed, 9 insertions, 4 deletions
diff --git a/gnu/java/util/regex/RETokenStart.java b/gnu/java/util/regex/RETokenStart.java index c3c133c9b..9f5fa73b9 100644 --- a/gnu/java/util/regex/RETokenStart.java +++ b/gnu/java/util/regex/RETokenStart.java @@ -55,10 +55,12 @@ class RETokenStart extends REToken { this.check_java_line_terminators = b; } + @Override int getMaximumLength() { - return 0; + return 0; } - + + @Override REMatch matchThis(CharIndexed input, REMatch mymatch) { // charAt(index-n) may be unknown on a Reader/InputStream. FIXME // Match after a newline if in multiline mode @@ -110,13 +112,16 @@ class RETokenStart extends REToken { mymatch : null; } - boolean returnsFixedLengthmatches() { return true; } + @Override + boolean returnsFixedLengthMatches() { return true; } + @Override int findFixedLengthMatches(CharIndexed input, REMatch mymatch, int max) { if (matchThis(input, mymatch) != null) return max; else return 0; } + @Override void dump(CPStringBuilder os) { os.append('^'); } diff --git a/gnu/javax/print/ipp/IppRequest.java b/gnu/javax/print/ipp/IppRequest.java index 05a6faae7..3de88715a 100644 --- a/gnu/javax/print/ipp/IppRequest.java +++ b/gnu/javax/print/ipp/IppRequest.java @@ -469,7 +469,7 @@ public class IppRequest } else { - new IppException("Unknown target operation attribute combination."); + throw new IppException("Unknown target operation attribute combination."); } writeAttributes(attributes); |