From 626673dcfb30b74dde141f1bfa3487881c711897 Mon Sep 17 00:00:00 2001 From: Andrew Haley Date: Tue, 27 Apr 2010 17:30:46 +0000 Subject: 2010-04-27 Andrew Haley * java/util/concurrent/CopyOnWriteArrayList.java: Fix for empty list. --- java/util/concurrent/CopyOnWriteArrayList.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'java') diff --git a/java/util/concurrent/CopyOnWriteArrayList.java b/java/util/concurrent/CopyOnWriteArrayList.java index 0e76625c6..1ac5b956d 100644 --- a/java/util/concurrent/CopyOnWriteArrayList.java +++ b/java/util/concurrent/CopyOnWriteArrayList.java @@ -452,7 +452,12 @@ public class CopyOnWriteArrayList public synchronized boolean remove(Object element) { E[] snapshot = this.data; - E[] newData = (E[]) new Object[snapshot.length - 1]; + int len = snapshot.length; + + if (len == 0) + return false; + + E[] newData = (E[]) new Object[len - 1]; // search the element to remove while filling the backup array // this way we can run this method in O(n) -- cgit v1.2.1