<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/cmake.git/Source/cmQtAutoMocUic.cxx, branch master</title>
<subtitle>gitlab.kitware.com: cmake/cmake.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/'/>
<entry>
<title>AutoMoc: Fix verbose mode message</title>
<updated>2023-02-07T15:59:51+00:00</updated>
<author>
<name>Joerg Bornemann</name>
<email>joerg.bornemann@qt.io</email>
</author>
<published>2023-02-07T07:36:35+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=d0f49327f9ea820e2adf1efa7d747b12a463d78c'/>
<id>d0f49327f9ea820e2adf1efa7d747b12a463d78c</id>
<content type='text'>
AutoMoc generates because moc settings changed, not uic.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
AutoMoc generates because moc settings changed, not uic.
</pre>
</div>
</content>
</entry>
<entry>
<title>automoc: Remove existing output file before invoking moc</title>
<updated>2022-12-05T02:56:00+00:00</updated>
<author>
<name>Jason Haslam</name>
<email>jason@scitools.com</email>
</author>
<published>2022-12-05T02:56:00+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=318ec0756045818c6697ac3a496e8e8b8e984484'/>
<id>318ec0756045818c6697ac3a496e8e8b8e984484</id>
<content type='text'>
Remove the output file before invoking moc in case the case of source file has
changed on disk. Recent versions of clang warn when the case of the include
directive (which does change) doesn't match the case of the file on disk.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove the output file before invoking moc in case the case of source file has
changed on disk. Recent versions of clang warn when the case of the include
directive (which does change) doesn't match the case of the file on disk.</pre>
</div>
</content>
</entry>
<entry>
<title>automoc: revert attempts to silence linker warning on macos</title>
<updated>2022-09-07T14:35:17+00:00</updated>
<author>
<name>Brad King</name>
<email>brad.king@kitware.com</email>
</author>
<published>2022-09-07T14:32:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=e08d34eda13ac6e856f7038a09aa52cc92612a64'/>
<id>e08d34eda13ac6e856f7038a09aa52cc92612a64</id>
<content type='text'>
We've made several attempts to add a dummy symbol to `mocs_compilation.cpp`
when there are no automoc sources:

* commit 4a9daae483 (automoc: silence linker warning on macos,
                     2022-05-25, v3.24.0-rc1~55^2)
* commit 844244ccdc (automoc: avoid compiler warnings in linker-warning-
                     silencing code, 2022-08-10, v3.24.1~6^2)
* commit fc8628389f (automoc: avoid more compiler warnings in linker-
                     warning-silencing code, 2022-08-29)

The last attempt derives a symbol name from the path to the source
file, but that breaks reproducible builds because it is not stable
w.r.t. the location of the build tree.  Revert all these attempts
for the 3.24 release series, and return to what 3.23 and below did.
Further investigation will be needed to resolve the original issue.

Fixes: #23937
Issue: #23551, #23823, #23823
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We've made several attempts to add a dummy symbol to `mocs_compilation.cpp`
when there are no automoc sources:

* commit 4a9daae483 (automoc: silence linker warning on macos,
                     2022-05-25, v3.24.0-rc1~55^2)
* commit 844244ccdc (automoc: avoid compiler warnings in linker-warning-
                     silencing code, 2022-08-10, v3.24.1~6^2)
* commit fc8628389f (automoc: avoid more compiler warnings in linker-
                     warning-silencing code, 2022-08-29)

The last attempt derives a symbol name from the path to the source
file, but that breaks reproducible builds because it is not stable
w.r.t. the location of the build tree.  Revert all these attempts
for the 3.24 release series, and return to what 3.23 and below did.
Further investigation will be needed to resolve the original issue.

Fixes: #23937
Issue: #23551, #23823, #23823
</pre>
</div>
</content>
</entry>
<entry>
<title>automoc: avoid more compiler warnings in linker-warning-silencing code</title>
<updated>2022-08-30T19:21:12+00:00</updated>
<author>
<name>Albert Astals Cid</name>
<email>aacid@kde.org</email>
</author>
<published>2022-08-28T22:14:53+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=fc8628389fc0fac964d699eb471f981bcd4edf60'/>
<id>fc8628389fc0fac964d699eb471f981bcd4edf60</id>
<content type='text'>
Revise the approach from commit 844244ccdc (automoc: avoid compiler
warnings in linker-warning-silencing code, 2022-08-10, v3.24.1~6^2)
to avoid `-Wmissing-declarations` warnings too.

Issue: #23823
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Revise the approach from commit 844244ccdc (automoc: avoid compiler
warnings in linker-warning-silencing code, 2022-08-10, v3.24.1~6^2)
to avoid `-Wmissing-declarations` warnings too.

Issue: #23823
</pre>
</div>
</content>
</entry>
<entry>
<title>automoc: avoid compiler warnings in linker-warning-silencing code</title>
<updated>2022-08-10T20:03:11+00:00</updated>
<author>
<name>Albert Astals Cid</name>
<email>aacid@kde.org</email>
</author>
<published>2022-08-10T16:01:31+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=844244ccdc020f8b16d02478ceb4f79fd696aed6'/>
<id>844244ccdc020f8b16d02478ceb4f79fd696aed6</id>
<content type='text'>
Revise the code added by !7296 (merged).
Make cmake_automoc_silence_linker_warning less warning-y.
Fix weak-tables clang warning and copyable-polymorph clazy warning.

Fixes: #23823
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Revise the code added by !7296 (merged).
Make cmake_automoc_silence_linker_warning less warning-y.
Fix weak-tables clang warning and copyable-polymorph clazy warning.

Fixes: #23823
</pre>
</div>
</content>
</entry>
<entry>
<title>Source: Convince LCC that RAII variables are used</title>
<updated>2022-06-13T15:07:35+00:00</updated>
<author>
<name>Brad King</name>
<email>brad.king@kitware.com</email>
</author>
<published>2022-06-13T15:07:35+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=beb07cdda7d291db9cac7e4bb6bf0d1c84601143'/>
<id>beb07cdda7d291db9cac7e4bb6bf0d1c84601143</id>
<content type='text'>
Extend the change from commit 5ad8862318 (Source: Convince NVHPC that
RAII variables are used, 2021-04-26, v3.21.0-rc1~254^2~1) to apply to
LCC too.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extend the change from commit 5ad8862318 (Source: Convince NVHPC that
RAII variables are used, 2021-04-26, v3.21.0-rc1~254^2~1) to apply to
LCC too.
</pre>
</div>
</content>
</entry>
<entry>
<title>automoc: silence linker warning on macos</title>
<updated>2022-06-01T04:12:08+00:00</updated>
<author>
<name>Tim Blechmann</name>
<email>tim@klingt.org</email>
</author>
<published>2022-05-25T02:36:18+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=4a9daae4832de862ee0f82e13784a93dcf5fafbe'/>
<id>4a9daae4832de862ee0f82e13784a93dcf5fafbe</id>
<content type='text'>
when an empty `mocs_compilation.cpp` is included in a static library,
the macos linker emits a warning:
```
/Applications/Xcode13.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib:
file: path/To/Library.a(mocs_compilation.cpp.o) has no symbols
```

we therefore generate a globally visible weak symbol in the form of a
virtual function table
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
when an empty `mocs_compilation.cpp` is included in a static library,
the macos linker emits a warning:
```
/Applications/Xcode13.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib:
file: path/To/Library.a(mocs_compilation.cpp.o) has no symbols
```

we therefore generate a globally visible weak symbol in the form of a
virtual function table
</pre>
</div>
</content>
</entry>
<entry>
<title>AUTOMOC: Automatically use options file for moc compiler</title>
<updated>2022-04-26T18:43:00+00:00</updated>
<author>
<name>Daniel Gehriger</name>
<email>dgehriger@globusmedical.com</email>
</author>
<published>2022-04-25T10:17:53+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=1c9cead051be019bcaa46f15d3587ca23214805b'/>
<id>1c9cead051be019bcaa46f15d3587ca23214805b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>AUTOUIC: Fix merging of --blah options not being detected for Qt6</title>
<updated>2021-10-05T12:29:16+00:00</updated>
<author>
<name>Craig Scott</name>
<email>craig.scott@crascit.com</email>
</author>
<published>2021-10-04T03:04:51+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=2a3116795528354b9e93238d057efa16b3635da8'/>
<id>2a3116795528354b9e93238d057efa16b3635da8</id>
<content type='text'>
When merging a new set of uic options with a base set of options,
such as when a source file has a non-empty AUTOUIC_OPTIONS
property, the test for whether to support options starting with
two hyphens was only testing if the Qt major version was exactly
5 rather than at least 5. That had the effect of preventing such
options from being merged correctly when using Qt6, so new and
base options would both be present instead of the single merged
option from the source file properties. Update the version check
and rename function arguments to avoid misrepresenting what
they mean.

Note that uic accepts long option names with a single hyphen too.
See Qt docs for QCommandLineParser::ParseAsLongOptions
for confirmation.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When merging a new set of uic options with a base set of options,
such as when a source file has a non-empty AUTOUIC_OPTIONS
property, the test for whether to support options starting with
two hyphens was only testing if the Qt major version was exactly
5 rather than at least 5. That had the effect of preventing such
options from being merged correctly when using Qt6, so new and
base options would both be present instead of the single merged
option from the source file properties. Update the version check
and rename function arguments to avoid misrepresenting what
they mean.

Note that uic accepts long option names with a single hyphen too.
See Qt docs for QCommandLineParser::ParseAsLongOptions
for confirmation.</pre>
</div>
</content>
</entry>
<entry>
<title>Source: Fix clang -Wextra-semi warnings</title>
<updated>2021-09-28T13:59:24+00:00</updated>
<author>
<name>Sean McBride</name>
<email>sean@rogue-research.com</email>
</author>
<published>2021-09-24T15:52:11+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/cmake.git/commit/?id=907d098838c99ee6c0c72ae0cdf1cc53dbf51ba2'/>
<id>907d098838c99ee6c0c72ae0cdf1cc53dbf51ba2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
