summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2019-02-28 11:02:53 -0500
committerBrad King <brad.king@kitware.com>2019-02-28 11:04:29 -0500
commit00c11208373cee958966d294e02114dc3900ac34 (patch)
tree915e03e93982c25aec743b36208e7371a65d040e
parente6897c72e7c59f7a0b82ed19c1bdb40d42f7adaa (diff)
downloadcmake-00c11208373cee958966d294e02114dc3900ac34.tar.gz
VS: Drop workaround needed only for VS 2019 preview 2 and 3
A temporary workaround added by commit 626c51f47b (VS: Update for Visual Studio 2019 Preview 2, 2019-01-24, v3.14.0-rc1~74^2) is no longer needed as of VS 2019 preview 4. Fixes: #18898
-rw-r--r--Source/cmVSSetupHelper.cxx8
1 files changed, 0 insertions, 8 deletions
diff --git a/Source/cmVSSetupHelper.cxx b/Source/cmVSSetupHelper.cxx
index 91a0e15124..c78361e261 100644
--- a/Source/cmVSSetupHelper.cxx
+++ b/Source/cmVSSetupHelper.cxx
@@ -190,14 +190,6 @@ bool cmVSSetupAPIHelper::GetVSInstanceInfo(
std::string const vcRoot = vsInstanceInfo.GetInstallLocation();
std::string vcToolsVersionFile =
vcRoot + "/VC/Auxiliary/Build/Microsoft.VCToolsVersion.default.txt";
- if (!cmSystemTools::PathExists(vcToolsVersionFile)) {
- // FIXME: VS 2019 Preview 2 installs the v142 toolset and does not
- // provide the plain `Microsoft.VCToolsVersion.default.txt` that v141
- // does. This should be fixed in preview 3 and this workaround can
- // be dropped. Otherwise, we may need to switch to globbing.
- vcToolsVersionFile = vcRoot +
- "/VC/Auxiliary/Build/Microsoft.VCToolsVersion.v142.default.txt";
- }
std::string vcToolsVersion;
cmsys::ifstream fin(vcToolsVersionFile.c_str());
if (!fin || !cmSystemTools::GetLineFromStream(fin, vcToolsVersion)) {