diff options
| author | Alex Turbov <i.zaufi@gmail.com> | 2019-06-30 12:23:35 +0300 |
|---|---|---|
| committer | Alex Turbov <i.zaufi@gmail.com> | 2019-06-30 13:15:29 +0300 |
| commit | 822abf1265eacdffee37d3ed55e41425b6602e27 (patch) | |
| tree | d816805907e666fd8ad962e90d4170bdb0f2c0e5 | |
| parent | 753373579e3dd8cf19f0fc18f4d9bec43a2d82e8 (diff) | |
| download | cmake-822abf1265eacdffee37d3ed55e41425b6602e27.tar.gz | |
list(POP_FRONT): Fix always assigning first item to output vars
Fixes: #19436
| -rw-r--r-- | Source/cmListCommand.cxx | 2 | ||||
| -rw-r--r-- | Tests/RunCMake/list/POP_FRONT.cmake | 13 |
2 files changed, 14 insertions, 1 deletions
diff --git a/Source/cmListCommand.cxx b/Source/cmListCommand.cxx index 5474afae4a..1b01ea2022 100644 --- a/Source/cmListCommand.cxx +++ b/Source/cmListCommand.cxx @@ -344,7 +344,7 @@ bool cmListCommand::HandlePopFrontCommand(std::vector<std::string> const& args) auto vi = varArgsExpanded.begin(); for (; vi != varArgsExpanded.end() && ai != args.cend(); ++ai, ++vi) { assert(!ai->empty()); - this->Makefile->AddDefinition(*ai, varArgsExpanded.front().c_str()); + this->Makefile->AddDefinition(*ai, vi->c_str()); } varArgsExpanded.erase(varArgsExpanded.begin(), vi); // Undefine the rest variables if the list gets empty earlier... diff --git a/Tests/RunCMake/list/POP_FRONT.cmake b/Tests/RunCMake/list/POP_FRONT.cmake index a2f8f3cae9..70f757a27a 100644 --- a/Tests/RunCMake/list/POP_FRONT.cmake +++ b/Tests/RunCMake/list/POP_FRONT.cmake @@ -77,3 +77,16 @@ endif() if(NOT test STREQUAL "two") message(FATAL_ERROR "`test` has unexpected value `${test}`") endif() + +# BUG 19436 +set(myList a b c) +list(POP_FRONT myList first second) +if(NOT first STREQUAL "a") + message(FATAL_ERROR "BUG#19436: `first` has unexpected value `${first}`") +endif() +if(NOT second STREQUAL "b") + message(FATAL_ERROR "BUG#19436: `second` has unexpected value `${second}`") +endif() +if(NOT myList STREQUAL "c") + message(FATAL_ERROR "BUG#19436: `myList` has unexpected value `${myList}`") +endif() |