summaryrefslogtreecommitdiff
path: root/DartConfig.cmake
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2018-10-30 09:37:07 -0400
committerBrad King <brad.king@kitware.com>2018-10-31 09:13:19 -0400
commita56edad6d61268204af8228b8d58fa26d8f72269 (patch)
tree0d3fb5b71f8f83db49b7eed811defe2902f48c44 /DartConfig.cmake
parentf87d5f13c29a961238ccf623d4954d2d0636adaa (diff)
downloadcmake-a56edad6d61268204af8228b8d58fa26d8f72269.tar.gz
CSharp: Fix regression in VS project type selection for custom target
A target created by `add_custom_target` should always be a `.vcxproj` file even if it has `.cs` sources involved in custom commands and such. The latter case was broken by refactoring in commit v3.12.0-rc1~160^2~7 (remove TargetIsCSharpOnly() and use methods from cmGeneratorTarget, 2018-03-19). The reason is that the `HasLanguage` method added by commit v3.12.0-rc1~239^2~6 (cmGeneratorTarget: add HasLanguage() as wrapper for GetLanguages(), 2018-03-19) does not check the target type and so is not a suitable check for deciding the project file extension. The `HasLanguage` method was an attempt at an abstraction that turns out not to work very well. Replace it with a dedicated `IsCSharpOnly` method that considers the target type, sources, and non-transitive `LINKER_LANGUAGE`. Fixes: #18515
Diffstat (limited to 'DartConfig.cmake')
0 files changed, 0 insertions, 0 deletions