diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-06-01 23:29:53 +0200 |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2016-06-02 08:24:04 -0400 |
| commit | 7f6b8d3399dd841b0d29bf74d2b31021738c4ef8 (patch) | |
| tree | 9b9184028cba2f16fdcc1c10ac5fb5467f09bff7 /Source/cmDependsFortran.cxx | |
| parent | d6754d37d593a0189809dcf98bc4fdf3a609f0a3 (diff) | |
| download | cmake-7f6b8d3399dd841b0d29bf74d2b31021738c4ef8.tar.gz | |
Simplify boolean expressions
Use clang-tidy's readability-simplify-boolean-expr checker.
After applying the fix-its, revise all changes *very* carefully.
Be aware of false positives and invalid changes.
Diffstat (limited to 'Source/cmDependsFortran.cxx')
| -rw-r--r-- | Source/cmDependsFortran.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/Source/cmDependsFortran.cxx b/Source/cmDependsFortran.cxx index 38e319d72f..a20fb9819f 100644 --- a/Source/cmDependsFortran.cxx +++ b/Source/cmDependsFortran.cxx @@ -654,10 +654,9 @@ bool cmDependsFortran::ModulesDiffer(const char* modFile, // but also do not include a date so we can fall through to // compare them without skipping any prefix. unsigned char hdr[2]; - bool okay = - finModFile.read(reinterpret_cast<char*>(hdr), 2) ? true : false; + bool okay = !finModFile.read(reinterpret_cast<char*>(hdr), 2).fail(); finModFile.seekg(0); - if (!(okay && hdr[0] == 0x1f && hdr[1] == 0x8b)) { + if (!okay || hdr[0] != 0x1f || hdr[1] != 0x8b) { const char seq[1] = { '\n' }; const int seqlen = 1; |