diff options
| author | Stephen Kelly <steveire@gmail.com> | 2016-06-09 09:57:47 +0200 |
|---|---|---|
| committer | Stephen Kelly <steveire@gmail.com> | 2016-06-12 22:09:27 +0200 |
| commit | 23f87e8157770c56d3aa568f3d1318f9b9070364 (patch) | |
| tree | 89f980aa45d40f513a42d5cc0e39b48ede696f07 /Source/cmMakefile.h | |
| parent | 54c65d5fb22c3cc53ecd707687c2f25b1643726b (diff) | |
| download | cmake-23f87e8157770c56d3aa568f3d1318f9b9070364.tar.gz | |
cmake: Remove force from IssueMessage API
The force parameter is ugly and makes the method harder to reason about
(issues the message ... but maybe it doesn't ... but then again you can
force it). It is a violation of
https://en.wikipedia.org/wiki/Interface_segregation_principle
and is the kind of thing described in a recent blog here:
http://code.joejag.com/2016/anti-if-the-missing-patterns.html
"Any time you see this you actually have two methods bundled into one.
That boolean represents an opportunity to name a concept in your code."
Diffstat (limited to 'Source/cmMakefile.h')
| -rw-r--r-- | Source/cmMakefile.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Source/cmMakefile.h b/Source/cmMakefile.h index c665b1f129..719c7648fc 100644 --- a/Source/cmMakefile.h +++ b/Source/cmMakefile.h @@ -715,8 +715,7 @@ public: cmMakefile* Makefile; }; - void IssueMessage(cmake::MessageType t, std::string const& text, - bool force = false) const; + void IssueMessage(cmake::MessageType t, std::string const& text) const; /** Set whether or not to report a CMP0000 violation. */ void SetCheckCMP0000(bool b) { this->CheckCMP0000 = b; } |