diff options
| author | Matthias Maennich <matthias@maennich.net> | 2017-09-19 15:54:08 +0200 |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2017-09-28 07:23:40 -0400 |
| commit | bb0ad1bea81f60cbbb2c66c2c0ab24ee12db0026 (patch) | |
| tree | 06db4eb05a227219eef3e265fef60f601640d051 /Source/cmXCodeScheme.h | |
| parent | 8cc33aeaec2798c9ff5a3af23e361ee22fa2ba95 (diff) | |
| download | cmake-bb0ad1bea81f60cbbb2c66c2c0ab24ee12db0026.tar.gz | |
Fix some occurrences using string by value rather than by const&
Fix issues diagnosed by clang-tidy
- performance-unnecessary-value-param
- performance-unnecessary-copy-initialization
Signed-off-by: Matthias Maennich <matthias@maennich.net>
Diffstat (limited to 'Source/cmXCodeScheme.h')
| -rw-r--r-- | Source/cmXCodeScheme.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/Source/cmXCodeScheme.h b/Source/cmXCodeScheme.h index def75b1246..e5e501a6fd 100644 --- a/Source/cmXCodeScheme.h +++ b/Source/cmXCodeScheme.h @@ -37,13 +37,13 @@ private: void WriteXCodeXCScheme(std::ostream& fout, const std::string& container); void WriteBuildAction(cmXMLWriter& xout, const std::string& container); - void WriteTestAction(cmXMLWriter& xout, std::string configuration, + void WriteTestAction(cmXMLWriter& xout, const std::string& configuration, const std::string& container); - void WriteLaunchAction(cmXMLWriter& xout, std::string configuration, + void WriteLaunchAction(cmXMLWriter& xout, const std::string& configuration, const std::string& container); - void WriteProfileAction(cmXMLWriter& xout, std::string configuration); - void WriteAnalyzeAction(cmXMLWriter& xout, std::string configuration); - void WriteArchiveAction(cmXMLWriter& xout, std::string configuration); + void WriteProfileAction(cmXMLWriter& xout, const std::string& configuration); + void WriteAnalyzeAction(cmXMLWriter& xout, const std::string& configuration); + void WriteArchiveAction(cmXMLWriter& xout, const std::string& configuration); void WriteBuildableReference(cmXMLWriter& xout, const cmXCodeObject* xcObj, const std::string& container); |