diff options
author | Brad King <brad.king@kitware.com> | 2020-06-29 16:45:43 -0400 |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2020-06-29 17:23:27 -0400 |
commit | df6b077625f86e4ec0d534f6cd88f8610c5b8f8a (patch) | |
tree | c2aa4271583dcad49c08570f90f8caf2b97c8451 /Source/cmake.h | |
parent | f2b84d24cfccf49b6332cf3f2ca164fd71ae023e (diff) | |
download | cmake-df6b077625f86e4ec0d534f6cd88f8610c5b8f8a.tar.gz |
cmake: Remove broken '--warn-unused-vars' option
This option has been broken since commit b9f9915516 (cmMakefile: Remove
VarUsageStack., 2015-05-17, v3.3.0-rc1~52^2). That commit removed the
check that an initialized variable has actually been used and caused the
option to warn on every variable ever set. This was not caught by the
test suite because the test for the feature only checked that warnings
appear when needed and not that they do not appear when not needed.
The option was never very practical to use. Remove it to avoid the
runtime cost of usage tracking and checks for every variable (which we
were doing even when the option was not used).
Diffstat (limited to 'Source/cmake.h')
-rw-r--r-- | Source/cmake.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/Source/cmake.h b/Source/cmake.h index c5d608f464..0c4f429f01 100644 --- a/Source/cmake.h +++ b/Source/cmake.h @@ -450,8 +450,6 @@ public: bool GetWarnUninitialized() { return this->WarnUninitialized; } void SetWarnUninitialized(bool b) { this->WarnUninitialized = b; } - bool GetWarnUnused() { return this->WarnUnused; } - void SetWarnUnused(bool b) { this->WarnUnused = b; } bool GetWarnUnusedCli() { return this->WarnUnusedCli; } void SetWarnUnusedCli(bool b) { this->WarnUnusedCli = b; } bool GetCheckSystemVars() { return this->CheckSystemVars; } @@ -605,7 +603,6 @@ private: TraceFormat TraceFormatVar = TRACE_HUMAN; cmGeneratedFileStream TraceFile; bool WarnUninitialized = false; - bool WarnUnused = false; bool WarnUnusedCli = true; bool CheckSystemVars = false; std::map<std::string, bool> UsedCliVariables; |