diff options
| author | Brad King <brad.king@kitware.com> | 2012-03-19 17:14:52 -0400 |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2012-03-20 09:01:02 -0400 |
| commit | b291d9e756b76ce85ebcc314c14de532e8ad477f (patch) | |
| tree | 1fa7e300567e215b929003dc913cea4a10225bc9 /Tests | |
| parent | 328c0f65c2a273c6adcdb11f96ee057d80014de2 (diff) | |
| download | cmake-b291d9e756b76ce85ebcc314c14de532e8ad477f.tar.gz | |
VS10: Fix external objects generated outside target (#13047)
Commit 9a6ff950 (Fix for bug where VS2010 did not use .obj files,
2011-04-01) assumed that if an external object is GENERATED that it is
the output of a custom command in the current target. If it is
generated by another target then VS will not automatically include the
external object in the current target. This bug was preserved by the
refactoring in the parent commit.
Instead use <None> for external objects generated by a custom command in
the current target and <Object> for all other external objects. Update
the ExternalOBJ test to cover this case.
Diffstat (limited to 'Tests')
| -rw-r--r-- | Tests/ExternalOBJ/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | Tests/ExternalOBJ/Sub/CMakeLists.txt | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/Tests/ExternalOBJ/CMakeLists.txt b/Tests/ExternalOBJ/CMakeLists.txt index f12de11d7d..683e7997c9 100644 --- a/Tests/ExternalOBJ/CMakeLists.txt +++ b/Tests/ExternalOBJ/CMakeLists.txt @@ -59,3 +59,5 @@ ADD_EXECUTABLE(ExternalOBJ executable.cxx ${CUSTOM_OBJECT}) # not didn't work. So, repeat the executable using the object # directly and not from the output of the copy. ADD_EXECUTABLE(ExternalOBJ2 executable.cxx ${EXTERNAL_OBJECT}) + +ADD_SUBDIRECTORY(Sub) diff --git a/Tests/ExternalOBJ/Sub/CMakeLists.txt b/Tests/ExternalOBJ/Sub/CMakeLists.txt new file mode 100644 index 0000000000..35cd30c7d7 --- /dev/null +++ b/Tests/ExternalOBJ/Sub/CMakeLists.txt @@ -0,0 +1,3 @@ +set_property(SOURCE ${CUSTOM_OBJECT} PROPERTY GENERATED 1) +add_executable(ExternalOBJSub ../executable.cxx ${CUSTOM_OBJECT}) +add_dependencies(ExternalOBJSub ExternalOBJ) # depend on generating target |