summaryrefslogtreecommitdiff
path: root/Source/cmSetPropertyCommand.cxx
diff options
context:
space:
mode:
Diffstat (limited to 'Source/cmSetPropertyCommand.cxx')
-rw-r--r--Source/cmSetPropertyCommand.cxx391
1 files changed, 150 insertions, 241 deletions
diff --git a/Source/cmSetPropertyCommand.cxx b/Source/cmSetPropertyCommand.cxx
index a03f6084bf..73f7437469 100644
--- a/Source/cmSetPropertyCommand.cxx
+++ b/Source/cmSetPropertyCommand.cxx
@@ -15,7 +15,6 @@
#include "cmSetTargetPropertiesCommand.h"
#include "cmSetTestsPropertiesCommand.h"
-
cmSetPropertyCommand::cmSetPropertyCommand()
{
this->AppendMode = false;
@@ -23,243 +22,205 @@ cmSetPropertyCommand::cmSetPropertyCommand()
this->Remove = true;
}
-bool cmSetPropertyCommand
-::InitialPass(std::vector<std::string> const& args, cmExecutionStatus &)
+bool cmSetPropertyCommand::InitialPass(std::vector<std::string> const& args,
+ cmExecutionStatus&)
{
- if(args.size() < 2 )
- {
+ if (args.size() < 2) {
this->SetError("called with incorrect number of arguments");
return false;
- }
+ }
// Get the scope on which to set the property.
std::vector<std::string>::const_iterator arg = args.begin();
cmProperty::ScopeType scope;
- if(*arg == "GLOBAL")
- {
+ if (*arg == "GLOBAL") {
scope = cmProperty::GLOBAL;
- }
- else if(*arg == "DIRECTORY")
- {
+ } else if (*arg == "DIRECTORY") {
scope = cmProperty::DIRECTORY;
- }
- else if(*arg == "TARGET")
- {
+ } else if (*arg == "TARGET") {
scope = cmProperty::TARGET;
- }
- else if(*arg == "SOURCE")
- {
+ } else if (*arg == "SOURCE") {
scope = cmProperty::SOURCE_FILE;
- }
- else if(*arg == "TEST")
- {
+ } else if (*arg == "TEST") {
scope = cmProperty::TEST;
- }
- else if(*arg == "CACHE")
- {
+ } else if (*arg == "CACHE") {
scope = cmProperty::CACHE;
- }
- else if(*arg == "INSTALL")
- {
+ } else if (*arg == "INSTALL") {
scope = cmProperty::INSTALL;
- }
- else
- {
+ } else {
std::ostringstream e;
e << "given invalid scope " << *arg << ". "
<< "Valid scopes are GLOBAL, DIRECTORY, "
- "TARGET, SOURCE, TEST, CACHE, INSTALL.";
+ "TARGET, SOURCE, TEST, CACHE, INSTALL.";
this->SetError(e.str());
return false;
- }
+ }
// Parse the rest of the arguments up to the values.
- enum Doing { DoingNone, DoingNames, DoingProperty, DoingValues };
+ enum Doing
+ {
+ DoingNone,
+ DoingNames,
+ DoingProperty,
+ DoingValues
+ };
Doing doing = DoingNames;
const char* sep = "";
- for(++arg; arg != args.end(); ++arg)
- {
- if(*arg == "PROPERTY")
- {
+ for (++arg; arg != args.end(); ++arg) {
+ if (*arg == "PROPERTY") {
doing = DoingProperty;
- }
- else if(*arg == "APPEND")
- {
+ } else if (*arg == "APPEND") {
doing = DoingNone;
this->AppendMode = true;
this->Remove = false;
this->AppendAsString = false;
- }
- else if(*arg == "APPEND_STRING")
- {
+ } else if (*arg == "APPEND_STRING") {
doing = DoingNone;
this->AppendMode = true;
this->Remove = false;
this->AppendAsString = true;
- }
- else if(doing == DoingNames)
- {
+ } else if (doing == DoingNames) {
this->Names.insert(*arg);
- }
- else if(doing == DoingProperty)
- {
+ } else if (doing == DoingProperty) {
this->PropertyName = *arg;
doing = DoingValues;
- }
- else if(doing == DoingValues)
- {
+ } else if (doing == DoingValues) {
this->PropertyValue += sep;
sep = ";";
this->PropertyValue += *arg;
this->Remove = false;
- }
- else
- {
+ } else {
std::ostringstream e;
e << "given invalid argument \"" << *arg << "\".";
this->SetError(e.str());
return false;
- }
}
+ }
// Make sure a property name was found.
- if(this->PropertyName.empty())
- {
+ if (this->PropertyName.empty()) {
this->SetError("not given a PROPERTY <name> argument.");
return false;
- }
+ }
// Dispatch property setting.
- switch(scope)
- {
- case cmProperty::GLOBAL: return this->HandleGlobalMode();
- case cmProperty::DIRECTORY: return this->HandleDirectoryMode();
- case cmProperty::TARGET: return this->HandleTargetMode();
- case cmProperty::SOURCE_FILE: return this->HandleSourceMode();
- case cmProperty::TEST: return this->HandleTestMode();
- case cmProperty::CACHE: return this->HandleCacheMode();
- case cmProperty::INSTALL: return this->HandleInstallMode();
+ switch (scope) {
+ case cmProperty::GLOBAL:
+ return this->HandleGlobalMode();
+ case cmProperty::DIRECTORY:
+ return this->HandleDirectoryMode();
+ case cmProperty::TARGET:
+ return this->HandleTargetMode();
+ case cmProperty::SOURCE_FILE:
+ return this->HandleSourceMode();
+ case cmProperty::TEST:
+ return this->HandleTestMode();
+ case cmProperty::CACHE:
+ return this->HandleCacheMode();
+ case cmProperty::INSTALL:
+ return this->HandleInstallMode();
case cmProperty::VARIABLE:
case cmProperty::CACHED_VARIABLE:
break; // should never happen
- }
+ }
return true;
}
bool cmSetPropertyCommand::HandleGlobalMode()
{
- if(!this->Names.empty())
- {
+ if (!this->Names.empty()) {
this->SetError("given names for GLOBAL scope.");
return false;
- }
+ }
// Set or append the property.
cmake* cm = this->Makefile->GetCMakeInstance();
const char* name = this->PropertyName.c_str();
- const char *value = this->PropertyValue.c_str();
- if (this->Remove)
- {
+ const char* value = this->PropertyValue.c_str();
+ if (this->Remove) {
value = 0;
- }
- if(this->AppendMode)
- {
+ }
+ if (this->AppendMode) {
cm->AppendProperty(name, value ? value : "", this->AppendAsString);
- }
- else
- {
+ } else {
cm->SetProperty(name, value);
- }
+ }
return true;
}
bool cmSetPropertyCommand::HandleDirectoryMode()
{
- if(this->Names.size() > 1)
- {
+ if (this->Names.size() > 1) {
this->SetError("allows at most one name for DIRECTORY scope.");
return false;
- }
+ }
// Default to the current directory.
cmMakefile* mf = this->Makefile;
// Lookup the directory if given.
- if(!this->Names.empty())
- {
+ if (!this->Names.empty()) {
// Construct the directory name. Interpret relative paths with
// respect to the current directory.
std::string dir = *this->Names.begin();
- if(!cmSystemTools::FileIsFullPath(dir.c_str()))
- {
+ if (!cmSystemTools::FileIsFullPath(dir.c_str())) {
dir = this->Makefile->GetCurrentSourceDirectory();
dir += "/";
dir += *this->Names.begin();
- }
+ }
// The local generators are associated with collapsed paths.
dir = cmSystemTools::CollapseFullPath(dir);
mf = this->Makefile->GetGlobalGenerator()->FindMakefile(dir);
- if (!mf)
- {
+ if (!mf) {
// Could not find the directory.
- this->SetError
- ("DIRECTORY scope provided but requested directory was not found. "
- "This could be because the directory argument was invalid or, "
- "it is valid but has not been processed yet.");
+ this->SetError(
+ "DIRECTORY scope provided but requested directory was not found. "
+ "This could be because the directory argument was invalid or, "
+ "it is valid but has not been processed yet.");
return false;
- }
}
+ }
// Set or append the property.
const char* name = this->PropertyName.c_str();
- const char *value = this->PropertyValue.c_str();
- if (this->Remove)
- {
+ const char* value = this->PropertyValue.c_str();
+ if (this->Remove) {
value = 0;
- }
- if(this->AppendMode)
- {
+ }
+ if (this->AppendMode) {
mf->AppendProperty(name, value ? value : "", this->AppendAsString);
- }
- else
- {
+ } else {
mf->SetProperty(name, value);
- }
+ }
return true;
}
bool cmSetPropertyCommand::HandleTargetMode()
{
- for(std::set<std::string>::const_iterator ni = this->Names.begin();
- ni != this->Names.end(); ++ni)
- {
- if (this->Makefile->IsAlias(*ni))
- {
+ for (std::set<std::string>::const_iterator ni = this->Names.begin();
+ ni != this->Names.end(); ++ni) {
+ if (this->Makefile->IsAlias(*ni)) {
this->SetError("can not be used on an ALIAS target.");
return false;
- }
- if(cmTarget* target = this->Makefile->FindTargetToUse(*ni))
- {
+ }
+ if (cmTarget* target = this->Makefile->FindTargetToUse(*ni)) {
// Handle the current target.
- if(!this->HandleTarget(target))
- {
+ if (!this->HandleTarget(target)) {
return false;
- }
}
- else
- {
+ } else {
std::ostringstream e;
e << "could not find TARGET " << *ni
<< ". Perhaps it has not yet been created.";
this->SetError(e.str());
return false;
- }
}
+ }
return true;
}
@@ -267,19 +228,15 @@ bool cmSetPropertyCommand::HandleTarget(cmTarget* target)
{
// Set or append the property.
const char* name = this->PropertyName.c_str();
- const char *value = this->PropertyValue.c_str();
- if (this->Remove)
- {
+ const char* value = this->PropertyValue.c_str();
+ if (this->Remove) {
value = 0;
- }
- if(this->AppendMode)
- {
+ }
+ if (this->AppendMode) {
target->AppendProperty(name, value, this->AppendAsString);
- }
- else
- {
+ } else {
target->SetProperty(name, value);
- }
+ }
// Check the resulting value.
target->CheckProperty(name, this->Makefile);
@@ -289,25 +246,20 @@ bool cmSetPropertyCommand::HandleTarget(cmTarget* target)
bool cmSetPropertyCommand::HandleSourceMode()
{
- for(std::set<std::string>::const_iterator ni = this->Names.begin();
- ni != this->Names.end(); ++ni)
- {
+ for (std::set<std::string>::const_iterator ni = this->Names.begin();
+ ni != this->Names.end(); ++ni) {
// Get the source file.
- if(cmSourceFile* sf = this->Makefile->GetOrCreateSource(*ni))
- {
- if(!this->HandleSource(sf))
- {
+ if (cmSourceFile* sf = this->Makefile->GetOrCreateSource(*ni)) {
+ if (!this->HandleSource(sf)) {
return false;
- }
}
- else
- {
+ } else {
std::ostringstream e;
e << "given SOURCE name that could not be found or created: " << *ni;
this->SetError(e.str());
return false;
- }
}
+ }
return true;
}
@@ -315,20 +267,16 @@ bool cmSetPropertyCommand::HandleSource(cmSourceFile* sf)
{
// Set or append the property.
const char* name = this->PropertyName.c_str();
- const char *value = this->PropertyValue.c_str();
- if (this->Remove)
- {
+ const char* value = this->PropertyValue.c_str();
+ if (this->Remove) {
value = 0;
- }
+ }
- if(this->AppendMode)
- {
+ if (this->AppendMode) {
sf->AppendProperty(name, value, this->AppendAsString);
- }
- else
- {
+ } else {
sf->SetProperty(name, value);
- }
+ }
return true;
}
@@ -336,37 +284,30 @@ bool cmSetPropertyCommand::HandleTestMode()
{
// Look for tests with all names given.
std::set<std::string>::iterator next;
- for(std::set<std::string>::iterator ni = this->Names.begin();
- ni != this->Names.end(); ni = next)
- {
+ for (std::set<std::string>::iterator ni = this->Names.begin();
+ ni != this->Names.end(); ni = next) {
next = ni;
++next;
- if(cmTest* test = this->Makefile->GetTest(*ni))
- {
- if(this->HandleTest(test))
- {
+ if (cmTest* test = this->Makefile->GetTest(*ni)) {
+ if (this->HandleTest(test)) {
this->Names.erase(ni);
- }
- else
- {
+ } else {
return false;
- }
}
}
+ }
// Names that are still left were not found.
- if(!this->Names.empty())
- {
+ if (!this->Names.empty()) {
std::ostringstream e;
e << "given TEST names that do not exist:\n";
- for(std::set<std::string>::const_iterator ni = this->Names.begin();
- ni != this->Names.end(); ++ni)
- {
+ for (std::set<std::string>::const_iterator ni = this->Names.begin();
+ ni != this->Names.end(); ++ni) {
e << " " << *ni << "\n";
- }
+ }
this->SetError(e.str());
return false;
- }
+ }
return true;
}
@@ -374,84 +315,66 @@ bool cmSetPropertyCommand::HandleTest(cmTest* test)
{
// Set or append the property.
const char* name = this->PropertyName.c_str();
- const char *value = this->PropertyValue.c_str();
- if (this->Remove)
- {
+ const char* value = this->PropertyValue.c_str();
+ if (this->Remove) {
value = 0;
- }
- if(this->AppendMode)
- {
+ }
+ if (this->AppendMode) {
test->AppendProperty(name, value, this->AppendAsString);
- }
- else
- {
+ } else {
test->SetProperty(name, value);
- }
+ }
return true;
}
bool cmSetPropertyCommand::HandleCacheMode()
{
- if(this->PropertyName == "ADVANCED")
- {
- if(!this->Remove &&
- !cmSystemTools::IsOn(this->PropertyValue.c_str()) &&
- !cmSystemTools::IsOff(this->PropertyValue.c_str()))
- {
+ if (this->PropertyName == "ADVANCED") {
+ if (!this->Remove && !cmSystemTools::IsOn(this->PropertyValue.c_str()) &&
+ !cmSystemTools::IsOff(this->PropertyValue.c_str())) {
std::ostringstream e;
e << "given non-boolean value \"" << this->PropertyValue
<< "\" for CACHE property \"ADVANCED\". ";
this->SetError(e.str());
return false;
- }
}
- else if(this->PropertyName == "TYPE")
- {
- if(!cmState::IsCacheEntryType(this->PropertyValue.c_str()))
- {
+ } else if (this->PropertyName == "TYPE") {
+ if (!cmState::IsCacheEntryType(this->PropertyValue.c_str())) {
std::ostringstream e;
e << "given invalid CACHE entry TYPE \"" << this->PropertyValue << "\"";
this->SetError(e.str());
return false;
- }
}
- else if(this->PropertyName != "HELPSTRING" &&
- this->PropertyName != "STRINGS" &&
- this->PropertyName != "VALUE")
- {
+ } else if (this->PropertyName != "HELPSTRING" &&
+ this->PropertyName != "STRINGS" &&
+ this->PropertyName != "VALUE") {
std::ostringstream e;
e << "given invalid CACHE property " << this->PropertyName << ". "
<< "Settable CACHE properties are: "
<< "ADVANCED, HELPSTRING, STRINGS, TYPE, and VALUE.";
this->SetError(e.str());
return false;
- }
+ }
- for(std::set<std::string>::const_iterator ni = this->Names.begin();
- ni != this->Names.end(); ++ni)
- {
+ for (std::set<std::string>::const_iterator ni = this->Names.begin();
+ ni != this->Names.end(); ++ni) {
// Get the source file.
cmMakefile* mf = this->GetMakefile();
cmake* cm = mf->GetCMakeInstance();
- const char* existingValue
- = cm->GetState()->GetCacheEntryValue(*ni);
- if(existingValue)
- {
- if(!this->HandleCacheEntry(*ni))
- {
+ const char* existingValue = cm->GetState()->GetCacheEntryValue(*ni);
+ if (existingValue) {
+ if (!this->HandleCacheEntry(*ni)) {
return false;
- }
}
- else
- {
+ } else {
std::ostringstream e;
e << "could not find CACHE variable " << *ni
<< ". Perhaps it has not yet been created.";
this->SetError(e.str());
return false;
- }
}
+ }
return true;
}
@@ -461,19 +384,15 @@ bool cmSetPropertyCommand::HandleCacheEntry(std::string const& cacheKey)
const char* name = this->PropertyName.c_str();
const char* value = this->PropertyValue.c_str();
cmState* state = this->Makefile->GetState();
- if (this->Remove)
- {
+ if (this->Remove) {
state->RemoveCacheEntryProperty(cacheKey, name);
- }
- if(this->AppendMode)
- {
+ }
+ if (this->AppendMode) {
state->AppendCacheEntryProperty(cacheKey, name, value,
- this->AppendAsString);
- }
- else
- {
+ this->AppendAsString);
+ } else {
state->SetCacheEntryProperty(cacheKey, name, value);
- }
+ }
return true;
}
@@ -482,25 +401,20 @@ bool cmSetPropertyCommand::HandleInstallMode()
{
cmake* cm = this->Makefile->GetCMakeInstance();
- for(std::set<std::string>::const_iterator i = this->Names.begin();
- i != this->Names.end(); ++i)
- {
- if(cmInstalledFile* file = cm->GetOrCreateInstalledFile(
- this->Makefile, *i))
- {
- if(!this->HandleInstall(file))
- {
+ for (std::set<std::string>::const_iterator i = this->Names.begin();
+ i != this->Names.end(); ++i) {
+ if (cmInstalledFile* file =
+ cm->GetOrCreateInstalledFile(this->Makefile, *i)) {
+ if (!this->HandleInstall(file)) {
return false;
- }
}
- else
- {
+ } else {
std::ostringstream e;
e << "given INSTALL name that could not be found or created: " << *i;
this->SetError(e.str());
return false;
- }
}
+ }
return true;
}
@@ -511,18 +425,13 @@ bool cmSetPropertyCommand::HandleInstall(cmInstalledFile* file)
cmMakefile* mf = this->Makefile;
- const char *value = this->PropertyValue.c_str();
- if (this->Remove)
- {
+ const char* value = this->PropertyValue.c_str();
+ if (this->Remove) {
file->RemoveProperty(name);
- }
- else if(this->AppendMode)
- {
+ } else if (this->AppendMode) {
file->AppendProperty(mf, name, value, this->AppendAsString);
- }
- else
- {
+ } else {
file->SetProperty(mf, name, value);
- }
+ }
return true;
}