summaryrefslogtreecommitdiff
path: root/Modules
Commit message (Collapse)AuthorAgeFilesLines
* ExternalProject: Add DOWNLOAD_EXTRACT_TIMESTAMP option and policyKasper Laudrup2022-05-052-5/+57
| | | | | | | | | | Add the option to keep the current filestamps when extracting an archive in ExternalProject_Add. Enabling this option makes the behavior consistent with how ExternalProject_Add is used when checking out code from revision control instead of an archive. Fixes: #22746
* Merge topic 'cuda-arch-verify'Brad King2022-05-031-3/+4
|\ | | | | | | | | | | | | | | 7bf5200699 CUDA: Restore CMAKE_CUDA_ARCHITECTURES support for -real and -virtual suffixes Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewd-by: Raul Tambre <raul@tambre.ee> Merge-request: !7218
| * CUDA: Restore CMAKE_CUDA_ARCHITECTURES support for -real and -virtual suffixesBrad King2022-04-291-3/+4
| | | | | | | | | | | | Fix the validation regex added by commit c267ed205a (CUDA: Defer architecture testing to the compiler testing step, 2022-04-25) to allow these values.
* | Merge topic 'findmpi_dont_variable_lang'Brad King2022-04-281-4/+4
|\ \ | |/ |/| | | | | | | | | c9c2e040aa FindMPI: Don't check for variables named the same as the languages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7208
| * FindMPI: Don't check for variables named the same as the languagesRobert Maynard2022-04-261-4/+4
| | | | | | | | | | We want to see if a language is inside `MPI_FIND_COMPONENTS` not if the variables `C`/`CXX` is set to a positive value.
* | Merge topic 'cuda-arch-verify'Brad King2022-04-283-160/+21
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | c267ed205a CUDA: Defer architecture testing to the compiler testing step Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Robert Maynard <robertjmaynard@gmail.com> Acked-by: Raul Tambre <raul@tambre.ee> Merge-request: !7202
| * | CUDA: Defer architecture testing to the compiler testing stepBrad King2022-04-253-160/+21
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Verifying the architectures during compiler identification is redundant, and requires a lot more up-front information than we should need. It also causes unsupported architectures to break the compiler id and version detection, so the resulting output from CMake does not report the compiler version, which is useful information to know why the specified architectures are not supported. The "detecting compiler ABI info" and "check for working compiler" steps already pass `CMAKE_CUDA_ARCHITECTURES` into their test projects. Therefore we can just drop the earlier architecture testing. Bad architectures will be reported as a not-working compiler, and the output will include the compiler's error message. This reverts the approach from: * commit 19cc5bc296 (CUDA: Throw error if user-specified architectures don't work, 2020-05-26, v3.18.0-rc1~79^2) * commit 650c1029a0 (CUDA: Detect non-working user-specified architectures on NVCC, 2020-05-28, v3.18.0-rc1~51^2) * commit 01428c5560 (CUDA: Fail fast if CMAKE_CUDA_ARCHITECTURES doesn't work during detection, 2020-08-29, v3.19.0-rc1~241^2). Their goal was in part to avoid waiting until the test for working compiler to detect unsupported architectures. However, experience has shown that failing earlier is more trouble than it's worth. Fixes: #23161 Issue: #20756
* | Merge topic 'FindThreads-cleanup'Brad King2022-04-271-37/+39
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | c53748a377 FindThreads: Factor out helper macro for libc check 564385194b FindThreads: Avoid repeating check for -pthread flag 41ef904e81 FindThreads: Simplify conditions for not-in-libc checks cbe7550d99 FindThreads: Remove unnecessary condition 1ee8c545dd FindThreads: Clarify internal helper macro names 5b5cd92363 FindThreads: Drop strange SunOS+pthread.h+thr_create combination c9bd462c08 FindThreads: Drop unused internal CMAKE_HAVE_THREADS_LIBRARY variable Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Acked-by: Rolf Eike Beer <eike@sf-mail.de> Merge-request: !7207
| * | FindThreads: Factor out helper macro for libc checkBrad King2022-04-261-9/+17
| | |
| * | FindThreads: Avoid repeating check for -pthread flagBrad King2022-04-261-1/+3
| | | | | | | | | | | | | | | When `THREADS_PREFER_PTHREAD_FLAG` is enabled, we check for it before the thread libraries. We do not need to check after them too.
| * | FindThreads: Simplify conditions for not-in-libc checksBrad King2022-04-261-13/+13
| | | | | | | | | | | | | | | If `CMAKE_HAVE_LIBC_PTHREAD` is true, we also set `Threads_FOUND` to true, which blocks all the other checks from running.
| * | FindThreads: Remove unnecessary conditionBrad King2022-04-261-26/+25
| | | | | | | | | | | | | | | | | | | | | | | | The `THREADS_HAVE_PTHREAD_ARG` cache entry cannot be defined unless FindThreads has already been executed, perhaps by a previous run of CMake, or a previous `find_package(Threads)` call. In that case, the other alternatives will also already have been checked and results cached.
| * | FindThreads: Clarify internal helper macro namesBrad King2022-04-261-7/+7
| | |
| * | FindThreads: Drop strange SunOS+pthread.h+thr_create combinationBrad King2022-04-261-4/+0
| | | | | | | | | | | | | | | Solaris has provided pthreads for a long time, so we probably never get to this combination anyway.
| * | FindThreads: Drop unused internal CMAKE_HAVE_THREADS_LIBRARY variableBrad King2022-04-261-3/+0
| |/ | | | | | | | | | | | | This internal variable has not been used since commit 46368eddfd (FindThreads: move checking of the -pthread compiler flag into a macro, 2014-10-06, v3.1.0-rc1~21^2~2). It has never been documented for public use.
* | Merge topic 'CUDAToolkit-cupti-include-dirs'Brad King2022-04-271-7/+20
|\ \ | | | | | | | | | | | | | | | | | | | | | e6b51a1b01 CUDAToolkit: Add include paths for CUDA::cupti Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Robert Maynard <robertjmaynard@gmail.com> Merge-request: !7200
| * | CUDAToolkit: Add include paths for CUDA::cuptiPeter Bell2022-04-261-7/+20
| |/ | | | | | | | | | | | | | | CUDA's cupti library has its headers in a seperate directory on a standard CUDA install, but `CUDA::cupti` only adds the default cuda include directory. Issue: #22761
* | Merge topic 'FindBoost-1.79'Brad King2022-04-271-1/+2
|\ \ | |/ |/| | | | | | | | | f90fb73651 FindBoost: Add support for Boost 1.79 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7205
| * FindBoost: Add support for Boost 1.79Brad King2022-04-261-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the list of known versions. Run the command cmake -DBOOST_DIR=/path/to/boost_1_79_0 \ -P Utilities/Scripts/BoostScanDeps.cmake to extract dependencies from the 1.79.0 source tree. They are the same as 1.78's dependencies, so just update the version check for warning about newer versions. Fixes: #23452
| * Merge topic 'CheckCompilerFlags-revert-linker-warnings' into release-3.23Brad King2022-04-222-1/+9
| |\ | | | | | | | | | | | | | | | | | | | | | | | | 4941887d7d CheckCompilerFlags: Revert "Catch linker warning about ignored flags" c2341ece47 CheckLinkerFlag: Catch linker warning when the checked flag is ignored Acked-by: Kitware Robot <kwrobot@kitware.com> Tested-by: buildbot <buildbot@kitware.com> Merge-request: !7190
* | \ Merge topic 'FindICU-show-found-libs'Brad King2022-04-221-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | c3c7e6d609 FindICU: Show location of found libraries Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7193
| * | | FindICU: Show location of found librariesDon Olmstead2022-04-211-2/+2
| | | | | | | | | | | | | | | | Announce locations of the libraries without the use of `ICU_DEBUG`.
* | | | Merge topic 'clang-cl-asm-msvc-runtime'Brad King2022-04-221-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | b41fab9285 Clang: populate MSVC runtime library abstraction table Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7048
| * | | | Clang: populate MSVC runtime library abstraction tableSaleem Abdulrasool2022-04-171-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | !3211 overlooked populating the runtime library selection flags for clang-cl in MSVC compatibility mode. There is no flag that needs to be passed, but the value is expected to be available by the generators. We simply provide the empty string to appease the generators without emitting any additional flags. Fixes: #23048
* | | | | Merge topic 'NO_CMAKE_INSTALL_PREFIX'Brad King2022-04-224-0/+13
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 42f7e39789 Find: Support per call disabling of CMAKE_INSTALL_PREFIX Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7163
| * | | | | Find: Support per call disabling of CMAKE_INSTALL_PREFIXRobert Maynard2022-04-154-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #23359
* | | | | | Merge topic 'CheckCompilerFlags-revert-linker-warnings'Brad King2022-04-222-1/+9
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | / | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | 4941887d7d CheckCompilerFlags: Revert "Catch linker warning about ignored flags" c2341ece47 CheckLinkerFlag: Catch linker warning when the checked flag is ignored Acked-by: Kitware Robot <kwrobot@kitware.com> Tested-by: buildbot <buildbot@kitware.com> Merge-request: !7190
| * | | | CheckCompilerFlags: Revert "Catch linker warning about ignored flags"Brad King2022-04-211-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert commit f745e0497e (CheckCompilerFlags: Catch linker warning about ignored flags, 2022-01-03, v3.23.0-rc1~174^2). It regressed cases where incidental linker warnings were previously tolerated. Revert the change pending further investigation. Fixes: #23432 Issue: #22961
| * | | | CheckLinkerFlag: Catch linker warning when the checked flag is ignoredBrad King2022-04-211-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to commit 219dde4ea8 (CheckPIESupported: now uses any SYSROOT settings, 2022-01-16, v3.23.0-rc1~110^2), the checks for `-pie` and `-no_pie` on macOS failed due to executing the compiler directly without any `-isysroot`, producing `ld: library not found for -lc++`. See issues #23053 and #19180. The failing check for `-pie` was a bug because it is supported on macOS, both for `x86_64` and `arm64`, and the commit fixed that check. However, `-no_pie` is not supported on macOS `arm64`. The above commit was only able to detect that due to commit f745e0497e (CheckCompilerFlags: Catch linker warning about ignored flags, 2022-01-03, v3.23.0-rc1~174^2), which we need to revert due to issue #23432. Instead, catch only the linker warning about the exact flag being checked.
* | | | | Merge topic 'FindPython-pypy-v7.3.9-support'Brad King2022-04-211-1/+12
|\ \ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | 5440eafaae FindPython: Add support for pypy v7.3.9 and uppers Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7189
| * | | | FindPython: Add support for pypy v7.3.9 and uppersMarc Chevrier2022-04-201-1/+12
| |/ / / | | | | | | | | | | | | | | | | | | | | Library name versioning has changed. Fixes: #23439
| * | | Merge topic 'doc-CheckPIESupported' into release-3.23Brad King2022-04-121-4/+7
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 91c859d1e5 CheckPIESupported: Prevent separate output lines running together ab5455aa79 Help: Correct/add missing details for CheckPIESupported Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7157
* | | | | CPack/DMG: Do not use CPACK_RESOURCE_FILE_LICENSE for SLA by defaultBrad King2022-04-141-2/+14
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Since macOS 12.0 deprecated the tools needed to attach a SLA to a `.dmg`, we should no longer do this by default. Add a policy to change the default to off. Fixes: #22978
* | | | Merge topic 'FindGit-no-easygit'Brad King2022-04-141-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | b656a3fa16 FindGit: remove EasyGit Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7169
| * | | | FindGit: remove EasyGitMichael Hirsch2022-04-111-3/+3
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Blame shows EasyGit was part of initial FindGit 11 years ago. I can hardly find Easy Git as a package. Given that Git is vital for many complex CMake projects, it seems good to ensure CMake FindGit is finding a Git program likely to work. Crucial CMake modules like FetchContent also use FindGit, emphasizing the importance of having a Git executable with proper functionality.
* | | | Merge topic 'FindwxWidgets-mingw'Brad King2022-04-121-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6fac8af9ca FindwxWidgets: set wxWidgets_FIND_STYLE to unix on MINGW Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7162
| * | | | FindwxWidgets: set wxWidgets_FIND_STYLE to unix on MINGWMehdi Chinoune2022-04-111-1/+1
| | | | | | | | | | | | | | | | | | | | The MinGW variant has wx-config which make it easier to find.
* | | | | Merge topic 'FindGLUT-freeglut'Brad King2022-04-121-1/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2c45465ffb FindGLUT: Search for freeglut as well using PkgConfig. 804ce3ee42 FindGLUT: Search for "freeglut" first On Windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7161
| * | | | | FindGLUT: Search for freeglut as well using PkgConfig.Mehdi Chinoune2022-04-111-0/+3
| | | | | |
| * | | | | FindGLUT: Search for "freeglut" first On WindowsMehdi Chinoune2022-04-111-1/+1
| |/ / / /
* | | | | Merge topic 'doc-CheckPIESupported'Brad King2022-04-121-4/+7
|\ \ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | 91c859d1e5 CheckPIESupported: Prevent separate output lines running together ab5455aa79 Help: Correct/add missing details for CheckPIESupported Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7157
| * | | | CheckPIESupported: Prevent separate output lines running togetherCraig Scott2022-04-111-1/+1
| | | | |
| * | | | Help: Correct/add missing details for CheckPIESupportedCraig Scott2022-04-111-3/+6
| | | | |
* | | | | Merge topic 'FindPostgreSQL-14'Brad King2022-04-121-2/+2
|\ \ \ \ \ | |_|_|/ / |/| | | / | | |_|/ | |/| | | | | | | | | | 23671318f3 FindPostgreSQL: add support for PostgreSQL 14 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7158
| * | | FindPostgreSQL: add support for PostgreSQL 14Even Rouault2022-04-111-2/+2
| |/ /
* | | Merge topic 'check-flag-fembed-bitcode-conflict'Brad King2022-04-111-0/+69
|\ \ \ | |/ / | | / | |/ |/| | | | | a10fc754a6 CheckSourceCompiles: Avoid linker warning with -fembed-bitcode Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7156
| * CheckSourceCompiles: Avoid linker warning with -fembed-bitcodeCraig Scott2022-04-091-0/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the Apple linker sees -headerpad_max_install_names and bitcode is enabled with a flag like -fembed-bitcode, it issues a warning and ignores the -headerpad_max_install_names flag. This causes unrelated compiler and linker flag checks to fail for valid flags. In f745e0497e (CheckCompilerFlags: Catch linker warning about ignored flags, 2022-01-03), we started detecting linker warnings, which caused a regression for projects that were setting -fembed-bitcode in their CMAKE_CXX_FLAGS or similar. Prevent that regression by removing the -headerpad_max_install_names linker flag when we know it will warn and be ignored anyway. Fixes: #23390 Issue: #23408
* | Merge topic 'CheckCompilerFlag-restore-env'Brad King2022-04-081-2/+2
|\ \ | |/ | | | | | | | | | | | | 9dd585d12c CheckCompilerFlag: Fix regression in locale environment preservation Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7153
| * CheckCompilerFlag: Fix regression in locale environment preservationBrad King2022-04-071-2/+2
| | | | | | | | | | | | | | Fix a typo from commit 660e0d80ae (internal/CheckCompilerFlag: rely on common configuration, 2022-01-12, v3.23.0-rc1~124^2~1) that caused locale environment variables to not be restored after they are set during the check.
| * Merge topic 'GNUInstallDirs-revert-multiarch-prefixes' into release-3.23Brad King2022-03-311-4/+2
| |\ | | | | | | | | | | | | | | | | | | | | | 624ec3692f GNUInstallDirs: Revert "Apply Debian multiarch LIBDIR to more prefixes" Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7127