From 6b1852874325520a418eb05ec3c2149c2eb194a2 Mon Sep 17 00:00:00 2001 From: Brad King Date: Tue, 1 Dec 2015 10:44:48 -0500 Subject: cmOrderDirectories: Factor out directory comparison Create an `IsSameDirectory` helper method. --- Source/cmOrderDirectories.cxx | 13 +++++++++---- Source/cmOrderDirectories.h | 3 +++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Source/cmOrderDirectories.cxx b/Source/cmOrderDirectories.cxx index 35ee127093..94912049be 100644 --- a/Source/cmOrderDirectories.cxx +++ b/Source/cmOrderDirectories.cxx @@ -73,10 +73,8 @@ public: { // Check if this directory conflicts with the entry. std::string const& dir = this->OD->OriginalDirectories[i]; - if(dir != this->Directory && - cmSystemTools::GetRealPath(dir) != - cmSystemTools::GetRealPath(this->Directory) && - this->FindConflict(dir)) + if (!this->OD->IsSameDirectory(dir, this->Directory) && + this->FindConflict(dir)) { // The library will be found in this directory but this is not // the directory named for it. Add an entry to make sure the @@ -639,3 +637,10 @@ void cmOrderDirectories::DiagnoseCycle() ->IssueMessage(cmake::WARNING, e.str(), this->Target->Target->GetBacktrace()); } + +bool cmOrderDirectories::IsSameDirectory(std::string const& l, + std::string const& r) +{ + return (l == r || + cmSystemTools::GetRealPath(l) == cmSystemTools::GetRealPath(r)); +} diff --git a/Source/cmOrderDirectories.h b/Source/cmOrderDirectories.h index 211c786d5a..0657e92dcb 100644 --- a/Source/cmOrderDirectories.h +++ b/Source/cmOrderDirectories.h @@ -80,6 +80,9 @@ private: struct ConflictList: public std::vector {}; std::vector ConflictGraph; + // Compare directories after resolving symlinks. + bool IsSameDirectory(std::string const& l, std::string const& r); + friend class cmOrderDirectoriesConstraint; friend class cmOrderDirectoriesConstraintLibrary; }; -- cgit v1.2.1