From aeda8fccebd6c6df2478a1a9d87cd0bc0f644190 Mon Sep 17 00:00:00 2001 From: Ruslan Baratov Date: Thu, 7 Jun 2018 13:28:23 +0300 Subject: Help: Package without components should use 'check_required_components' too Macro 'check_required_components' should be called even if there are no components provided by package. This will make sure error is reported in next cases: find_package(Foo CONFIG REQUIRED oops) # 'oops' treated as component find_package(Foo CONFIG REQUIRED COMPONENTS foo) # no components expected --- Modules/CMakePackageConfigHelpers.cmake | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/Modules/CMakePackageConfigHelpers.cmake b/Modules/CMakePackageConfigHelpers.cmake index e37f34f6fe..790d4084c5 100644 --- a/Modules/CMakePackageConfigHelpers.cmake +++ b/Modules/CMakePackageConfigHelpers.cmake @@ -102,13 +102,15 @@ # into the ``FooConfig.cmake`` file. # # ``check_required_components()`` should be called at the end of -# the ``FooConfig.cmake`` file if the package supports components. This macro -# checks whether all requested, non-optional components have been found, and if -# this is not the case, sets the ``Foo_FOUND`` variable to ``FALSE``, so that -# the package is considered to be not found. It does that by testing the -# ``Foo__FOUND`` variables for all requested required components. -# When using the ``NO_CHECK_REQUIRED_COMPONENTS_MACRO`` option, this macro is -# not generated into the ``FooConfig.cmake`` file. +# the ``FooConfig.cmake`` file. This macro checks whether all requested, +# non-optional components have been found, and if this is not the case, sets +# the ``Foo_FOUND`` variable to ``FALSE``, so that the package is considered to +# be not found. It does that by testing the ``Foo__FOUND`` +# variables for all requested required components. This macro should be +# called even if the package doesn't provide any components to make sure +# users are not specifying components erroneously. When using the +# ``NO_CHECK_REQUIRED_COMPONENTS_MACRO`` option, this macro is not generated +# into the ``FooConfig.cmake`` file. # # For an example see below the documentation for # :command:`write_basic_package_version_file()`. -- cgit v1.2.1