From 7c9db8f8139b945d4c55d9061e4ef122351b210d Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer Date: Sat, 10 Dec 2016 14:42:49 +0100 Subject: clang-tidy: apply performance-unnecessary-value-param fixes --- Source/cmAlgorithms.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'Source/cmAlgorithms.h') diff --git a/Source/cmAlgorithms.h b/Source/cmAlgorithms.h index 22f69fa4ef..7c683adf00 100644 --- a/Source/cmAlgorithms.h +++ b/Source/cmAlgorithms.h @@ -242,7 +242,7 @@ std::string cmJoin(Range const& r, const char* delimiter) } template -std::string cmJoin(Range const& r, std::string delimiter) +std::string cmJoin(Range const& r, std::string const& delimiter) { return cmJoin(r, delimiter.c_str()); } @@ -344,13 +344,13 @@ typename Range::const_iterator cmRemoveDuplicates(Range& r) } template -std::string cmWrap(std::string prefix, Range const& r, std::string suffix, - std::string sep) +std::string cmWrap(std::string const& prefix, Range const& r, + std::string const& suffix, std::string const& sep) { if (r.empty()) { return std::string(); } - return prefix + cmJoin(r, (suffix + sep + prefix).c_str()) + suffix; + return prefix + cmJoin(r, suffix + sep + prefix) + suffix; } template -- cgit v1.2.1