From c85bb007df37aad9f20355cdf4d7ca9af562cb20 Mon Sep 17 00:00:00 2001 From: Pavel Solodovnikov Date: Thu, 25 Jan 2018 16:59:33 +0300 Subject: Reduce allocation of temporary values on heap. - Use `std::move` while inserting temporary results into vectors. - Change `push_back` to `emplace_back` where appropriate. --- Source/cmGeneratorExpressionEvaluator.cxx | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'Source/cmGeneratorExpressionEvaluator.cxx') diff --git a/Source/cmGeneratorExpressionEvaluator.cxx b/Source/cmGeneratorExpressionEvaluator.cxx index c73d486017..dbc6840fce 100644 --- a/Source/cmGeneratorExpressionEvaluator.cxx +++ b/Source/cmGeneratorExpressionEvaluator.cxx @@ -132,9 +132,8 @@ std::string GeneratorExpressionContent::EvaluateParameters( int counter = 1; for (; pit != pend; ++pit, ++counter) { if (acceptsArbitraryContent && counter == numExpected) { - std::string lastParam = this->ProcessArbitraryContent( - node, identifier, context, dagChecker, pit); - parameters.push_back(lastParam); + parameters.push_back(this->ProcessArbitraryContent( + node, identifier, context, dagChecker, pit)); return std::string(); } std::string parameter; @@ -148,7 +147,7 @@ std::string GeneratorExpressionContent::EvaluateParameters( return std::string(); } } - parameters.push_back(parameter); + parameters.push_back(std::move(parameter)); } } -- cgit v1.2.1