From 68b4e3b255be7a8d0831d19b206f701efdb001c8 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Sun, 14 Nov 2021 16:55:38 +0900 Subject: cmGlobalVisualStudio8Generator: Fix the misaligned argument, stdPipesUTF8 The call to AddCustomCommandToTarget for "Checking File Globs" had misaligned arguments and previously passed `stdPipesUTF8` as `escapeOldStyle`. For now, set `escapeOldStyle` as `true`. Also `stdPipesUTF8` is `true` here. --- Source/cmGlobalVisualStudio8Generator.cxx | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'Source/cmGlobalVisualStudio8Generator.cxx') diff --git a/Source/cmGlobalVisualStudio8Generator.cxx b/Source/cmGlobalVisualStudio8Generator.cxx index 1e45813bb9..c4da8c3475 100644 --- a/Source/cmGlobalVisualStudio8Generator.cxx +++ b/Source/cmGlobalVisualStudio8Generator.cxx @@ -203,11 +203,17 @@ bool cmGlobalVisualStudio8Generator::AddCheckTarget() std::vector byproducts; byproducts.push_back(cm->GetGlobVerifyStamp()); - lg.AddCustomCommandToTarget(CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts, - no_depends, verifyCommandLines, - cmCustomCommandType::PRE_BUILD, - "Checking File Globs", no_working_directory, - cmPolicies::NEW, stdPipesUTF8); + lg.AddCustomCommandToTarget( + CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts, no_depends, + verifyCommandLines, cmCustomCommandType::PRE_BUILD, + "Checking File Globs", no_working_directory, cmPolicies::NEW, + /*escapeOldStyle=*/true, + /*uses_terminal=*/false, + /*depfile=*/"", + /*job_pool=*/"", + /*command_expand_lists=*/false, + /*objLibCommands=*/cmObjectLibraryCommands::Reject, + /*stdPipesUTF8=*/stdPipesUTF8); // Ensure ZERO_CHECK always runs in Visual Studio using MSBuild, // otherwise the prebuild command will not be run. -- cgit v1.2.1