From 175d8c4bf6505eeb02bb588527f3ff7b5eb143b9 Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 9 Sep 2019 13:38:01 -0400 Subject: clang-tidy: Resolve performance-unnecessary-value-param diagnostics Fix diagnostics that appear on macOS with clang-tidy-8. Suppress cases where we intentionally take an argument by value to let the caller choose whether to copy or move. --- Source/cmVariableWatchCommand.cxx | 1 + 1 file changed, 1 insertion(+) (limited to 'Source/cmVariableWatchCommand.cxx') diff --git a/Source/cmVariableWatchCommand.cxx b/Source/cmVariableWatchCommand.cxx index db23efdc70..f9f7d66174 100644 --- a/Source/cmVariableWatchCommand.cxx +++ b/Source/cmVariableWatchCommand.cxx @@ -91,6 +91,7 @@ static void deleteVariableWatchCallbackData(void* client_data) class FinalAction { public: + /* NOLINTNEXTLINE(performance-unnecessary-value-param) */ FinalAction(cmMakefile* makefile, std::string variable) : Action(std::make_shared(makefile, std::move(variable))) { -- cgit v1.2.1