From 6e3e8827faf0bf2363ecf9035b5573e715e52fb2 Mon Sep 17 00:00:00 2001 From: Alex Turbov Date: Wed, 26 Oct 2022 15:09:54 +0400 Subject: Refactor: `cmGlobalGeneratorFactory::GetDocumentation` returns entry Before, a documentation entry was in/out parameter. Now it's a normal return value. This also makes possible to eliminate defaulted default ctor for `cmDocumentationEntry` for C++ 11. Also, simplify `cmake::AppendGlobalGeneratorsDocumentation()`. --- Source/cmake.cxx | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'Source/cmake.cxx') diff --git a/Source/cmake.cxx b/Source/cmake.cxx index 62f926e6b9..befcb55135 100644 --- a/Source/cmake.cxx +++ b/Source/cmake.cxx @@ -2949,17 +2949,15 @@ void cmake::AppendGlobalGeneratorsDocumentation( std::vector& v) { const auto defaultGenerator = this->EvaluateDefaultGlobalGenerator(); - const std::string defaultName = defaultGenerator->GetName(); - bool foundDefaultOne = false; + const auto defaultName = defaultGenerator->GetName(); + auto foundDefaultOne = false; for (const auto& g : this->Generators) { - cmDocumentationEntry e; - g->GetDocumentation(e); - if (!foundDefaultOne && cmHasPrefix(e.Name, defaultName)) { - e.CustomNamePrefix = '*'; + v.emplace_back(g->GetDocumentation()); + if (!foundDefaultOne && cmHasPrefix(v.back().Name, defaultName)) { + v.back().CustomNamePrefix = '*'; foundDefaultOne = true; } - v.push_back(std::move(e)); } } -- cgit v1.2.1