summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Hughes <richard@hughsie.com>2017-12-28 20:53:00 +0000
committerRichard Hughes <richard@hughsie.com>2017-12-28 20:58:43 +0000
commitc14aafa17209d6f502df5ae26ef1bc0ebcec004e (patch)
treee7e627606525bf546bd0805c6d934290898f6c62
parent668aafbd2edeb5eff31d96268ef095dfceb97f9a (diff)
downloadcolord-c14aafa17209d6f502df5ae26ef1bc0ebcec004e.tar.gz
trivial: Fix a harmless clang warning
-rw-r--r--src/cd-main.c14
1 files changed, 4 insertions, 10 deletions
diff --git a/src/cd-main.c b/src/cd-main.c
index a226b4a..514ae5c 100644
--- a/src/cd-main.c
+++ b/src/cd-main.c
@@ -2046,7 +2046,6 @@ cd_main_load_plugin (CdMainPrivate *priv,
CdPluginEnabledFunc plugin_enabled = NULL;
CdPluginGetDescFunc plugin_desc = NULL;
CdPlugin *plugin;
- gboolean ret = FALSE;
GModule *module;
/* open the plugin and import all symbols */
@@ -2061,10 +2060,8 @@ cd_main_load_plugin (CdMainPrivate *priv,
}
/* get description */
- ret = g_module_symbol (module,
- "cd_plugin_get_description",
- (gpointer *) &plugin_desc);
- if (!ret) {
+ if (!g_module_symbol (module, "cd_plugin_get_description",
+ (gpointer *) &plugin_desc)) {
g_set_error_literal (error,
CD_CLIENT_ERROR,
CD_CLIENT_ERROR_INTERNAL,
@@ -2074,12 +2071,9 @@ cd_main_load_plugin (CdMainPrivate *priv,
}
/* give the module the option to opt-out */
- ret = g_module_symbol (module,
- "cd_plugin_enabled",
- (gpointer *) &plugin_enabled);
- if (ret) {
+ if (g_module_symbol (module, "cd_plugin_enabled",
+ (gpointer *) &plugin_enabled)) {
if (!plugin_enabled ()) {
- ret = FALSE;
g_set_error_literal (error,
CD_CLIENT_ERROR,
CD_CLIENT_ERROR_NOT_SUPPORTED,