diff options
| author | Rainer Orth <ro@gcc.gnu.org> | 2019-07-08 22:08:33 +0000 |
|---|---|---|
| committer | Rainer Orth <ro@gcc.gnu.org> | 2019-07-08 22:08:33 +0000 |
| commit | 158799d7b6c7aa15526fdc0c4be6a4985eefa189 (patch) | |
| tree | 0cdee2203116721f97674619d02049c76d096537 | |
| parent | c26180eea9e9386a71334aabc571bf4bd6167a3f (diff) | |
| download | compiler-rt-158799d7b6c7aa15526fdc0c4be6a4985eefa189.tar.gz | |
[Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris
There's no point to manually create the __start___sancov_guards and __stop___sancov_guards
sections and labels on Solaris any longer. They were originally introduced in
https://reviews.llvm.org/D40899 and https://reviews.llvm.org/D40903.
- The Solaris 11.4 ld supports creating them out of the box.
- We already unconditionally use Solaris 11.4 features like the ld -z gnu-version-script-compat option and fully working .preinit_array support in compiler-rt.
- The current files don't assemble on SPARC because the assembler syntax may be different between /bin/as and GNU as.
Tested on amd64-pc-solaris2.11.
Differential Revision: https://reviews.llvm.org/D63601
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@365399 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/sanitizer_common/CMakeLists.txt | 32 | ||||
| -rw-r--r-- | lib/sanitizer_common/sancov_begin.S | 5 | ||||
| -rw-r--r-- | lib/sanitizer_common/sancov_end.S | 5 |
3 files changed, 0 insertions, 42 deletions
diff --git a/lib/sanitizer_common/CMakeLists.txt b/lib/sanitizer_common/CMakeLists.txt index 75794163d..f523561cd 100644 --- a/lib/sanitizer_common/CMakeLists.txt +++ b/lib/sanitizer_common/CMakeLists.txt @@ -273,38 +273,6 @@ add_compiler_rt_object_libraries(RTSanitizerCommonSymbolizerNoHooks CFLAGS ${SANITIZER_NO_WEAK_HOOKS_CFLAGS} DEFS ${SANITIZER_COMMON_DEFINITIONS}) -if(OS_NAME MATCHES "SunOS") - # Solaris ld doesn't support the non-standard GNU ld extension of adding - # __start_SECNAME and __stop_SECNAME labels to sections whose names are - # valid C identifiers. Instead we add our own definitions for the - # __sancov_guards section. - add_compiler_rt_object_libraries(SancovBegin - ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH} - SOURCES sancov_begin.S - CFLAGS ${SANITIZER_CFLAGS} - DEFS ${SANITIZER_COMMON_DEFINITIONS}) - - add_compiler_rt_runtime(clang_rt.sancov_begin - STATIC - ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH} - OBJECT_LIBS SancovBegin - CFLAGS ${SANITIZER_CFLAGS} - DEFS ${SANITIZER_COMMON_DEFINITIONS}) - - add_compiler_rt_object_libraries(SancovEnd - ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH} - SOURCES sancov_end.S - CFLAGS ${SANITIZER_CFLAGS} - DEFS ${SANITIZER_COMMON_DEFINITIONS}) - - add_compiler_rt_runtime(clang_rt.sancov_end - STATIC - ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH} - OBJECT_LIBS SancovEnd - CFLAGS ${SANITIZER_CFLAGS} - DEFS ${SANITIZER_COMMON_DEFINITIONS}) -endif() - if(WIN32) add_compiler_rt_object_libraries(SanitizerCommonWeakInterception ${SANITIZER_COMMON_SUPPORTED_OS} diff --git a/lib/sanitizer_common/sancov_begin.S b/lib/sanitizer_common/sancov_begin.S deleted file mode 100644 index c8ad0a0bc..000000000 --- a/lib/sanitizer_common/sancov_begin.S +++ /dev/null @@ -1,5 +0,0 @@ - .type __start___sancov_guards,@object - .globl __start___sancov_guards - .section __sancov_guards,"aw",@progbits - .p2align 2 -__start___sancov_guards: diff --git a/lib/sanitizer_common/sancov_end.S b/lib/sanitizer_common/sancov_end.S deleted file mode 100644 index 31117b1c0..000000000 --- a/lib/sanitizer_common/sancov_end.S +++ /dev/null @@ -1,5 +0,0 @@ - .type __stop___sancov_guards,@object - .globl __stop___sancov_guards - .section __sancov_guards,"aw",@progbits - .p2align 2 -__stop___sancov_guards: |