From a3c35609db34edb3dbe9238bf2aa282e0714d6f3 Mon Sep 17 00:00:00 2001 From: Timur Iskhodzhanov Date: Tue, 6 May 2014 08:21:50 +0000 Subject: [ASan/Win] Don't crash when ASAN_OPTIONS have disable_core=1 Reviewed at http://reviews.llvm.org/D3610 git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@208070 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/asan/asan_rtl.cc | 3 ++- lib/sanitizer_common/sanitizer_win.cc | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/asan/asan_rtl.cc b/lib/asan/asan_rtl.cc index f10047a0d..6f5057285 100644 --- a/lib/asan/asan_rtl.cc +++ b/lib/asan/asan_rtl.cc @@ -178,7 +178,8 @@ static void ParseFlagsFromString(Flags *f, const char *str) { ParseFlag(str, &f->disable_core, "disable_core", "Disable core dumping. By default, disable_core=1 on 64-bit to avoid " - "dumping a 16T+ core file."); + "dumping a 16T+ core file. " + "Ignored on OSes that don't dump core by default."); ParseFlag(str, &f->allow_reexec, "allow_reexec", "Allow the tool to re-exec the program. This may interfere badly with " diff --git a/lib/sanitizer_common/sanitizer_win.cc b/lib/sanitizer_common/sanitizer_win.cc index d7d1c36ea..ec6ce994b 100644 --- a/lib/sanitizer_common/sanitizer_win.cc +++ b/lib/sanitizer_common/sanitizer_win.cc @@ -185,7 +185,7 @@ void DumpProcessMap() { } void DisableCoreDumper() { - UNIMPLEMENTED(); + // Do nothing. } void ReExec() { -- cgit v1.2.1