From 496afe6f6ddb3a65c9ed300d74485789a1269207 Mon Sep 17 00:00:00 2001 From: Ravi Prasad RK Date: Thu, 14 Apr 2016 10:46:55 +0530 Subject: gweb: Add NULL check before use As per code logic, 'begin' and 'end' will never be NULL. So, NULL check for g_strdup() call is redundant. --- gweb/gweb.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'gweb') diff --git a/gweb/gweb.c b/gweb/gweb.c index 5f18a0e6..6ce5028a 100644 --- a/gweb/gweb.c +++ b/gweb/gweb.c @@ -1465,6 +1465,9 @@ GWebParser *g_web_parser_new(const char *begin, const char *end, { GWebParser *parser; + if (!begin || !end) + return NULL; + parser = g_try_new0(GWebParser, 1); if (!parser) return NULL; @@ -1473,12 +1476,6 @@ GWebParser *g_web_parser_new(const char *begin, const char *end, parser->begin_token = g_strdup(begin); parser->end_token = g_strdup(end); - - if (!parser->begin_token) { - g_free(parser); - return NULL; - } - parser->func = func; parser->user_data = user_data; -- cgit v1.2.1