From 990a7d902f574d3ce5067444fa5cbe76b793b8e2 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Tue, 20 Dec 2022 16:26:14 +0100 Subject: conntrack: Fix for unused assignment in do_command_ct() The variable is overwritten immediately in the next iteration and the loop can't exit before doing that. Instead of dropping the assignment, one could add a return code check - but since event_cb() never fails, that check is pointless as well. Fixes: e0dac21ed02e3 ("conntrack: use libmnl for conntrack events") Signed-off-by: Phil Sutter --- src/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conntrack.c b/src/conntrack.c index aa6323d..07fae3d 100644 --- a/src/conntrack.c +++ b/src/conntrack.c @@ -3479,7 +3479,7 @@ static int do_command_ct(const char *progname, struct ct_cmd *cmd, strerror(errno)); break; } - res = mnl_cb_run(buf, res, 0, 0, event_cb, cmd); + mnl_cb_run(buf, res, 0, 0, event_cb, cmd); } mnl_socket_close(event_sock->mnl); break; -- cgit v1.2.1