diff options
| author | Vadim Bendebury <vbendeb@google.com> | 2022-09-06 10:26:20 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-07 00:21:58 +0000 |
| commit | 27ff437ee579e03bc0a584a0be1e11b2629bbffb (patch) | |
| tree | a3bc980037a60d403b07ef02a08d53c8ad566ca0 /.checkpatch.conf | |
| parent | 8cc24f9c7f076d25869a167efdc504b1e49947e1 (diff) | |
| download | chrome-ec-27ff437ee579e03bc0a584a0be1e11b2629bbffb.tar.gz | |
gsctool: fix compilation problems
It turns out that due to a bug in ./Makefile gsctool is always
compiled with -O0. Fixing the make file bug highlighted a bug in
gsctool code where a return value of getline() was left unchecked.
This patch fixes the gsctool compilation problem.
BUG=b:245028043
TEST=Verified that gsctool now builds successfully with -O3. Verified
that attempts to set password are properly failed when entered
passwords are of different length and succeed otherwise.
Change-Id: I8a3f337f3d40ff14a23162fab796b5b02f6cc664
Signed-off-by: Vadim Bendebury <vbendeb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3876011
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Diffstat (limited to '.checkpatch.conf')
0 files changed, 0 insertions, 0 deletions