summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDawid Niedzwiecki <dn@semihalf.com>2021-04-15 11:40:31 +0200
committerCommit Bot <commit-bot@chromium.org>2021-04-16 17:46:14 +0000
commit49836da4a8993037f59a3d0c1b01b6c3692c4e1c (patch)
treed26d27b16807fbdf905441ed5c572d7af15810c0
parentb686030ee72d482a9729ba54a1d6dcbaa7772d01 (diff)
downloadchrome-ec-49836da4a8993037f59a3d0c1b01b6c3692c4e1c.tar.gz
zephyr: lazor: Fix GPIO interrupt table
We use GPIO edge falling interrupts for some events. These one were initialized incorrectly with EC GPIO flags instead of Zephyr GPIO flags, thus the interrupts were not triggered. Change GPIO_INT_* to GPIO_INT_EDGE_* for all of them. BUG=b:182398910 BRANCH=none TEST=Build Zephyr EC for Lazor, flash Limozeen board and boot to OS, Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Id10aa010071d44f2d714eb9673ec7cad300bdf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2825909 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
-rw-r--r--zephyr/projects/trogdor/lazor/include/gpio_map.h25
1 files changed, 15 insertions, 10 deletions
diff --git a/zephyr/projects/trogdor/lazor/include/gpio_map.h b/zephyr/projects/trogdor/lazor/include/gpio_map.h
index e47ad980ac..3c0a6baddb 100644
--- a/zephyr/projects/trogdor/lazor/include/gpio_map.h
+++ b/zephyr/projects/trogdor/lazor/include/gpio_map.h
@@ -32,7 +32,8 @@
power_button_interrupt) \
GPIO_INT(GPIO_VOLUME_DOWN_L, GPIO_INT_EDGE_BOTH, button_interrupt) \
GPIO_INT(GPIO_VOLUME_UP_L, GPIO_INT_EDGE_BOTH, button_interrupt) \
- GPIO_INT(GPIO_SWITCHCAP_PG_INT_L, GPIO_INT_FALLING, ln9310_interrupt) \
+ GPIO_INT(GPIO_SWITCHCAP_PG_INT_L, GPIO_INT_EDGE_FALLING, \
+ ln9310_interrupt) \
GPIO_INT(GPIO_AP_RST_L, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \
GPIO_INT(GPIO_AP_SUSPEND, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \
GPIO_INT(GPIO_DEPRECATED_AP_RST_REQ, GPIO_INT_EDGE_BOTH, \
@@ -41,14 +42,18 @@
GPIO_INT(GPIO_PS_HOLD, GPIO_INT_EDGE_BOTH, power_signal_interrupt) \
GPIO_INT(GPIO_WARM_RESET_L, GPIO_INT_EDGE_BOTH, \
power_signal_interrupt) \
- GPIO_INT(GPIO_USB_C0_PD_INT_ODL, GPIO_INT_FALLING, tcpc_alert_event) \
- GPIO_INT(GPIO_USB_C1_PD_INT_ODL, GPIO_INT_FALLING, tcpc_alert_event) \
- GPIO_INT(GPIO_USB_C0_SWCTL_INT_ODL, GPIO_INT_FALLING, ppc_interrupt) \
- GPIO_INT(GPIO_USB_C1_SWCTL_INT_ODL, GPIO_INT_FALLING, ppc_interrupt) \
- GPIO_INT(GPIO_USB_C0_BC12_INT_L, GPIO_INT_FALLING, usb0_evt) \
- GPIO_INT(GPIO_USB_C1_BC12_INT_L, GPIO_INT_FALLING, usb1_evt) \
- GPIO_INT(GPIO_USB_A0_OC_ODL, GPIO_INT_BOTH, usba_oc_interrupt) \
- GPIO_INT(GPIO_CCD_MODE_ODL, GPIO_INT_FALLING, board_connect_c0_sbu)
-
+ GPIO_INT(GPIO_USB_C0_PD_INT_ODL, GPIO_INT_EDGE_FALLING, \
+ tcpc_alert_event) \
+ GPIO_INT(GPIO_USB_C1_PD_INT_ODL, GPIO_INT_EDGE_FALLING, \
+ tcpc_alert_event) \
+ GPIO_INT(GPIO_USB_C0_SWCTL_INT_ODL, GPIO_INT_EDGE_FALLING, \
+ ppc_interrupt) \
+ GPIO_INT(GPIO_USB_C1_SWCTL_INT_ODL, GPIO_INT_EDGE_FALLING, \
+ ppc_interrupt) \
+ GPIO_INT(GPIO_USB_C0_BC12_INT_L, GPIO_INT_EDGE_FALLING, usb0_evt) \
+ GPIO_INT(GPIO_USB_C1_BC12_INT_L, GPIO_INT_EDGE_FALLING, usb1_evt) \
+ GPIO_INT(GPIO_USB_A0_OC_ODL, GPIO_INT_EDGE_BOTH, usba_oc_interrupt) \
+ GPIO_INT(GPIO_CCD_MODE_ODL, GPIO_INT_EDGE_FALLING, \
+ board_connect_c0_sbu)
#endif /* __ZEPHYR_GPIO_MAP_H */