diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2021-10-01 21:14:13 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-10-01 23:33:06 +0000 |
| commit | 533640b6d2ce1189b8c0559ec69e1d64202d2c8b (patch) | |
| tree | ac4451830c680131f8dc6dd3fbb82126c29a0868 | |
| parent | 90bbe7d16a96041dc7ddb4ababeaf6b079c3d5b7 (diff) | |
| download | chrome-ec-533640b6d2ce1189b8c0559ec69e1d64202d2c8b.tar.gz | |
board/burnet: Fix enum type
"enum ec_led_colors" was used here instead of "enum led_color".
Fixes the following clang warning:
board/burnet/led.c:85:28: error: implicit conversion from enumeration type
'enum led_color' to different enumeration type 'enum ec_led_colors'
[-Werror,-Wenum-conversion]
rv = led_set_color_power(color);
~~~~~~~~~~~~~~~~~~~ ^~~~~
board/burnet/led.c:112:23: error: implicit conversion from enumeration type
'enum led_color' to different enumeration type 'enum ec_led_colors'
[-Werror,-Wenum-conversion]
led_set_color_power(LED_WHITE);
~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~
board/burnet/led.c:115:25: error: implicit conversion from enumeration type
'enum led_color' to different enumeration type 'enum ec_led_colors'
[-Werror,-Wenum-conversion]
(power_tick & 0x2) ? LED_WHITE : LED_OFF);
^~~~~~~~~
board/burnet/led.c:115:37: error: implicit conversion from enumeration type
'enum led_color' to different enumeration type 'enum ec_led_colors'
[-Werror,-Wenum-conversion]
(power_tick & 0x2) ? LED_WHITE : LED_OFF);
^~~~~~~
board/burnet/led.c:117:23: error: implicit conversion from enumeration type
'enum led_color' to different enumeration type 'enum ec_led_colors'
[-Werror,-Wenum-conversion]
led_set_color_power(LED_OFF);
~~~~~~~~~~~~~~~~~~~ ^~~~~~~
BRANCH=none
BUG=b:172020503
TEST=CC=arm-none-eabi-clang BOARD=burnet -j
TEST=./util/compare_build.sh -b all
=> MATCH
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ie530c1cd3603652748349a65f80242694884f6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3199736
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
| -rw-r--r-- | board/burnet/led.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/burnet/led.c b/board/burnet/led.c index 1f2b75325c..06ae68609e 100644 --- a/board/burnet/led.c +++ b/board/burnet/led.c @@ -52,7 +52,7 @@ static int led_set_color_battery(enum led_color color) return EC_SUCCESS; } -static int led_set_color_power(enum ec_led_colors color) +static int led_set_color_power(enum led_color color) { switch (color) { case LED_OFF: |