summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Coggin <dcoggin@google.com>2021-09-29 18:15:15 -0700
committerCommit Bot <commit-bot@chromium.org>2021-10-04 16:33:51 +0000
commit7b5b661b1f38feb3ff5297290bcb4c321d8f9701 (patch)
tree7c4bbfa8ad5221fb27b4666fd8dbaa21be58ed7b
parentce01ddef20bb8ab21facb71bed25fe9afbc33522 (diff)
downloadchrome-ec-7b5b661b1f38feb3ff5297290bcb4c321d8f9701.tar.gz
brask: modify gpio.inc
This patch enables pullups and pulldowns on floating USB control signals on brask proto0 released schematics. BUG=None BRANCH=None TEST=make BOARD=brask Change-Id: I9fc52777c2d2059f372c3cd74c5fd3539a7187f5 Signed-off-by: Daniel Coggin <dcoggin@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3195313 Reviewed-by: caveh jalali <caveh@chromium.org> Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Commit-Queue: Zhuohao Lee <zhuohao@chromium.org>
-rw-r--r--board/brask/gpio.inc14
1 files changed, 7 insertions, 7 deletions
diff --git a/board/brask/gpio.inc b/board/brask/gpio.inc
index 1e73ae1d03..b79690c903 100644
--- a/board/brask/gpio.inc
+++ b/board/brask/gpio.inc
@@ -107,17 +107,17 @@ GPIO(EC_I2C_USB_C1_TCPC_SDA, PIN(F, 2), GPIO_INPUT)
/* USBA */
GPIO(EN_PP5000_USBA, PIN(D, 7), GPIO_OUT_LOW)
GPIO(USB_A0_OC_ODL, PIN(3, 1), GPIO_INPUT)
-GPIO(USB_A1_OC_ODL, PIN(3, 0), GPIO_INPUT)
-GPIO(USB_A2_OC_ODL, PIN(2, 7), GPIO_INPUT)
-GPIO(USB_A3_OC_ODL, PIN(2, 6), GPIO_INPUT)
+GPIO(USB_A1_OC_ODL, PIN(3, 0), GPIO_INPUT | GPIO_PULL_UP)
+GPIO(USB_A2_OC_ODL, PIN(2, 7), GPIO_INPUT | GPIO_PULL_UP)
+GPIO(USB_A3_OC_ODL, PIN(2, 6), GPIO_INPUT | GPIO_PULL_UP)
GPIO(USB_A0_STATUS_L, PIN(2, 1), GPIO_INPUT)
GPIO(USB_A1_STATUS_L, PIN(2, 0), GPIO_INPUT)
GPIO(USB_A2_STATUS_L, PIN(1, 7), GPIO_INPUT)
GPIO(USB_A3_STATUS_L, PIN(1, 6), GPIO_INPUT)
-GPIO(USB_A_LOW_PWR0_OD, PIN(1, 5), GPIO_INPUT)
-GPIO(USB_A_LOW_PWR1_OD, PIN(1, 4), GPIO_INPUT)
-GPIO(USB_A_LOW_PWR2_OD, PIN(1, 1), GPIO_INPUT)
-GPIO(USB_A_LOW_PWR3_OD, PIN(1, 0), GPIO_INPUT)
+GPIO(USB_A_LOW_PWR0_OD, PIN(1, 5), GPIO_INPUT | GPIO_PULL_DOWN)
+GPIO(USB_A_LOW_PWR1_OD, PIN(1, 4), GPIO_INPUT | GPIO_PULL_DOWN)
+GPIO(USB_A_LOW_PWR2_OD, PIN(1, 1), GPIO_INPUT | GPIO_PULL_DOWN)
+GPIO(USB_A_LOW_PWR3_OD, PIN(1, 0), GPIO_INPUT | GPIO_PULL_DOWN)
/* LED */
/* TODO(b/197471359): LED implementation */