diff options
| author | Caveh Jalali <caveh@chromium.org> | 2021-04-10 01:03:12 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-04-16 00:12:35 +0000 |
| commit | bb5ea6072edc23b4e258bc19a90881a4c88290fc (patch) | |
| tree | 9b1db54765e69a1c3ca4c394c085d8595945ba7d | |
| parent | d8354778f4af8c5a58dddb82b9f539d7b5be4a27 (diff) | |
| download | chrome-ec-bb5ea6072edc23b4e258bc19a90881a4c88290fc.tar.gz | |
bq25710: Sort registers in numerical order
This sorts the register reporting in the charger_dump command to be
numeric order. The original order was probably motivated by the bq25710
datasheet which lists registers out of order. The bq25720 datasheet
lists registers in numeric order which makes cross referencing easier.
BRANCH=none
BUG=b:185190976
TEST=buildall passes
Change-Id: I79eca2d1926bd87d77d710e812fc6d18e4b4d2e8
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2819587
Reviewed-by: Boris Mittelberg <bmbm@google.com>
| -rw-r--r-- | driver/charger/bq25710.c | 14 | ||||
| -rw-r--r-- | driver/charger/bq25710.h | 14 |
2 files changed, 14 insertions, 14 deletions
diff --git a/driver/charger/bq25710.c b/driver/charger/bq25710.c index 3607650dcd..994f4b418a 100644 --- a/driver/charger/bq25710.c +++ b/driver/charger/bq25710.c @@ -655,6 +655,13 @@ static int console_bq25710_dump_regs(int argc, char **argv) BQ25710_REG_CHARGE_OPTION_0, BQ25710_REG_CHARGE_CURRENT, BQ25710_REG_MAX_CHARGE_VOLTAGE, + BQ25710_REG_CHARGER_STATUS, + BQ25710_REG_PROCHOT_STATUS, + BQ25710_REG_IIN_DPM, + BQ25710_REG_ADC_VBUS_PSYS, + BQ25710_REG_ADC_IBAT, + BQ25710_REG_ADC_CMPIN_IIN, + BQ25710_REG_ADC_VSYS_VBAT, BQ25710_REG_CHARGE_OPTION_1, BQ25710_REG_CHARGE_OPTION_2, BQ25710_REG_CHARGE_OPTION_3, @@ -665,13 +672,6 @@ static int console_bq25710_dump_regs(int argc, char **argv) BQ25720_REG_CHARGE_OPTION_4, BQ25720_REG_VMIN_ACTIVE_PROTECTION, #endif - BQ25710_REG_CHARGER_STATUS, - BQ25710_REG_PROCHOT_STATUS, - BQ25710_REG_IIN_DPM, - BQ25710_REG_ADC_VBUS_PSYS, - BQ25710_REG_ADC_IBAT, - BQ25710_REG_ADC_CMPIN_IIN, - BQ25710_REG_ADC_VSYS_VBAT, BQ25710_REG_OTG_VOLTAGE, BQ25710_REG_OTG_CURRENT, BQ25710_REG_INPUT_VOLTAGE, diff --git a/driver/charger/bq25710.h b/driver/charger/bq25710.h index 248fad338a..2c0e1ba876 100644 --- a/driver/charger/bq25710.h +++ b/driver/charger/bq25710.h @@ -17,6 +17,13 @@ #define BQ25710_REG_CHARGE_OPTION_0 0x12 #define BQ25710_REG_CHARGE_CURRENT 0x14 #define BQ25710_REG_MAX_CHARGE_VOLTAGE 0x15 +#define BQ25710_REG_CHARGER_STATUS 0x20 +#define BQ25710_REG_PROCHOT_STATUS 0x21 +#define BQ25710_REG_IIN_DPM 0x22 +#define BQ25710_REG_ADC_VBUS_PSYS 0x23 +#define BQ25710_REG_ADC_IBAT 0x24 +#define BQ25710_REG_ADC_CMPIN_IIN 0x25 +#define BQ25710_REG_ADC_VSYS_VBAT 0x26 #define BQ25710_REG_CHARGE_OPTION_1 0x30 #define BQ25710_REG_CHARGE_OPTION_2 0x31 #define BQ25710_REG_CHARGE_OPTION_3 0x32 @@ -27,13 +34,6 @@ #define BQ25720_REG_CHARGE_OPTION_4 0x36 #define BQ25720_REG_VMIN_ACTIVE_PROTECTION 0x37 #endif -#define BQ25710_REG_CHARGER_STATUS 0x20 -#define BQ25710_REG_PROCHOT_STATUS 0x21 -#define BQ25710_REG_IIN_DPM 0x22 -#define BQ25710_REG_ADC_VBUS_PSYS 0x23 -#define BQ25710_REG_ADC_IBAT 0x24 -#define BQ25710_REG_ADC_CMPIN_IIN 0x25 -#define BQ25710_REG_ADC_VSYS_VBAT 0x26 #define BQ25710_REG_OTG_VOLTAGE 0x3B #define BQ25710_REG_OTG_CURRENT 0x3C #define BQ25710_REG_INPUT_VOLTAGE 0x3D |