diff options
| author | Alexandru M Stan <amstan@chromium.org> | 2020-01-27 17:26:03 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-01 01:11:01 +0000 |
| commit | c825ad974c4086c282f1f4383a47619f6c0b207d (patch) | |
| tree | 85baff9fe2de4f67d0443520f48d394e6bfee361 | |
| parent | 71da3cda2154a29aa919bea21820df963c780831 (diff) | |
| download | chrome-ec-c825ad974c4086c282f1f4383a47619f6c0b207d.tar.gz | |
trogdor: Add more prints in the power sequence
For two of the complicated cases in the power sequence, the ec is being very
chatty but it's hard to understand why it's doing certain things (or if there
was an exception). Add more prints to be clearer.
BRANCH=None
TEST=releasing warm reset via servo should have an extra print on
why it's going to S5 and back to S0
TEST="apreset" with bad AP firmware will cause EC to complain
BUG=b/148188311
Change-Id: I2d53dfc553639ecec0792d78676b0899e3e76780
Signed-off-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2023404
Reviewed-by: Wai-Hong Tam <waihong@google.com>
| -rw-r--r-- | power/sc7180.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/power/sc7180.c b/power/sc7180.c index fafe244abd..7d8b5b9cb0 100644 --- a/power/sc7180.c +++ b/power/sc7180.c @@ -195,6 +195,8 @@ void chipset_warm_reset_interrupt(enum gpio_signal signal) * POWER_GOOD drop that triggers an interrupt to * high-Z both AP_RST_L and PS_HOLD. */ + CPRINTS("Long warm reset ended, " + "cold resetting to restore sanity."); request_cold_reset(); } /* If not overdriven, just a normal power-up, do nothing. */ @@ -686,8 +688,10 @@ void chipset_reset(enum chipset_reset_reason reason) rv = power_wait_signals_timeout(IN_AP_RST_ASSERTED, PMIC_POWER_AP_RESPONSE_TIMEOUT); /* Exception case: PMIC not work as expected, request a cold reset */ - if (rv != EC_SUCCESS) + if (rv != EC_SUCCESS) { + CPRINTS("AP refuses to warm reset. Cold resetting."); request_cold_reset(); + } } /** |