diff options
| author | Peter Marheine <pmarheine@chromium.org> | 2022-11-03 16:07:19 +1100 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-11-03 23:55:02 +0000 |
| commit | 5e39fae931d7fe889fd073f1ba3016f84855a61b (patch) | |
| tree | ebc74b04234cbc522800fc0751ccbbf135c9924a | |
| parent | 640434be3f364234f29576b7c3ab7b9417259175 (diff) | |
| download | chrome-ec-5e39fae931d7fe889fd073f1ba3016f84855a61b.tar.gz | |
nissa/npcx: re-enable some shell conveniences
We've received complaints from other developers that the minimal shell
isn't nice to use. Since we can turn on a number of the conveniences
without losing all of the gains from turning on minimal shell, do that.
Summarized effect of various options on flash size:
| Configuration | Flash used | Size increase |
|--------------------------------------|------------|---------------|
| Baseline | 245084 | 0 |
| SHELL_HISTORY | 245936 | 852 |
| SHELL_TAB | 245944 | 860 |
| SHELL_TAB + SHELL_TAB_AUTOCOMPLETION | 246176 | 1092 |
| SHELL_HELP | 248592 | 3508 |
| KERNEL_SHELL | 247448 | 2364 |
| all of the above | 252844 | 7760 |
| SHELL_MINIMAL=n | 260396 | 15312 |
BUG=b:230486318
TEST=zmake build nivviks
BRANCH=none
Change-Id: I7ffb89b5d1dd437f300724334337d64e6110c6d1
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4000344
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Andrew McRae <amcrae@google.com>
| -rw-r--r-- | zephyr/projects/nissa/npcx_program.conf | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/zephyr/projects/nissa/npcx_program.conf b/zephyr/projects/nissa/npcx_program.conf index d1b7a56bcc..ae672cb63a 100644 --- a/zephyr/projects/nissa/npcx_program.conf +++ b/zephyr/projects/nissa/npcx_program.conf @@ -30,8 +30,14 @@ CONFIG_PLATFORM_EC_USB_PD_TCPC_LPM_EXIT_DEBOUNCE_US=100000 CONFIG_PLATFORM_EC_USB_PD_5V_EN_CUSTOM=y # type C port 1 redriver CONFIG_PLATFORM_EC_USBC_RETIMER_ANX7483=y -# Save some space + +# Save some flash space, but retain some useful features CONFIG_SHELL_MINIMAL=y +CONFIG_SHELL_HISTORY=y +CONFIG_SHELL_TAB=y +CONFIG_SHELL_TAB_AUTOCOMPLETION=y +CONFIG_SHELL_HELP=y +CONFIG_KERNEL_SHELL=y # FRS enable CONFIG_PLATFORM_EC_USB_PD_FRS=y |