diff options
| author | Divya Sasidharan <divya.s.sasidharan@intel.com> | 2018-10-04 15:06:13 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-05 12:10:02 +0000 |
| commit | 991730e2104525bd14a4b5307a9b3a6c4a874272 (patch) | |
| tree | 6e8fa501b77493737eca41e10682e3ea8f6b6b0c | |
| parent | 026f308016365484e37c1379ccc868605cb41681 (diff) | |
| download | chrome-ec-991730e2104525bd14a4b5307a9b3a6c4a874272.tar.gz | |
CHERRY-PICK: nocturne: Add internal pull-ups to unused strap pins
This change prevents leakage current on strap
pins and saves around 1mW on nocturne.
BUG=b:117139495
BRANCH=firmware-nocturne-10984.B
TEST=On Nocturne, saved EC power by 1mW
Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/1275136
Reviewed-by: Roy Mingi Park <roy.mingi.park@intel.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Roy Mingi Park <roy.mingi.park@intel.com>
Tested-by: Roy Mingi Park <roy.mingi.park@intel.com>
Change-Id: I419402fa67e2497c25dad974b9e3d5a5984681bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2160870
Tested-by: Patryk Duda <pdk@semihalf.com>
Commit-Queue: Patryk Duda <pdk@semihalf.com>
| -rw-r--r-- | board/nocturne/gpio.inc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/board/nocturne/gpio.inc b/board/nocturne/gpio.inc index 66a4320bf5..75d2275424 100644 --- a/board/nocturne/gpio.inc +++ b/board/nocturne/gpio.inc @@ -93,6 +93,10 @@ GPIO(EC_I2C0_POWER_SDA, PIN(B, 4), GPIO_INPUT) GPIO(EC_I2C4_BATTERY_SCL, PIN(F, 3), GPIO_INPUT) GPIO(EC_I2C4_BATTERY_SDA, PIN(F, 2), GPIO_INPUT) +/* Strap pins */ +GPIO(GPO66_NC, PIN(6, 6), GPIO_INPUT | GPIO_PULL_UP) +GPIO(GPOB6_NC, PIN(B, 6), GPIO_INPUT | GPIO_PULL_UP) + /* Alternate mode configuration */ /* UART pins */ ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, 0) /* Cr50 requires no pullups. */ |