diff options
| author | Craig Hesling <hesling@chromium.org> | 2020-04-13 12:22:41 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-05 01:59:28 +0000 |
| commit | a4820cc7079cffc315c04b792429f6392b193b20 (patch) | |
| tree | f81a772d64f2671936213860b0c9851d9a36f06b | |
| parent | b97108239ef5dc2eea1076c1d25878179fe5305a (diff) | |
| download | chrome-ec-a4820cc7079cffc315c04b792429f6392b193b20.tar.gz | |
bloonchipper: Enable pulldown on SPI master
This enables the internal pulldown for the SPI master's
CLK, MISO, and MOSI lines to the fingerprint sensor.
The specific issue this is assumed to fix is the SPI CLK's
idle state before signaling and idle state after signaling.
This issue is hinted to in the STM32F412's reference manual by
the following note:
"""
The idle state of SCK must correspond to the polarity selected
in the SPIx_CR1 register (by pulling up SCK if CPOL=1 or pulling
down SCK if CPOL=0).
"""
BRANCH=none
BUG=b:151190204
TEST=Test sensor version, fpenroll, and fpmatch on dragonclaw dev board
TEST=# On Dratini w/fingerprint
# Test enroll and match
time for i in {1..10000}; do out=$(ectool --name=cros_fp fpinfo | awk '/Fingerprint sensor/{print $7 " " $8}'); echo "Iter $i: '$out'"; if [[ "$out" != "model 21f" ]]; then echo "# FAIL !"; break; fi; done | tee ~/log.txt
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: If5c9ce9e4e0c565959c4768b19ac002175c71c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2148012
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
| -rw-r--r-- | board/hatch_fp/gpio.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/hatch_fp/gpio.inc b/board/hatch_fp/gpio.inc index 3389d4a0a4..fb5aef0ecb 100644 --- a/board/hatch_fp/gpio.inc +++ b/board/hatch_fp/gpio.inc @@ -50,4 +50,4 @@ ALTERNATE(PIN_MASK(A, 0x00f0), GPIO_ALT_SPI, MODULE_SPI, 0) * configured it as a GPIO above and the SPI_MASTER module expects to use it * in software NSS management mode, not hardware management mode. */ -ALTERNATE(PIN_MASK(B, 0xE000), GPIO_ALT_SPI, MODULE_SPI_MASTER, 0) +ALTERNATE(PIN_MASK(B, 0xE000), GPIO_ALT_SPI, MODULE_SPI_MASTER, GPIO_PULL_DOWN) |