diff options
| author | Diana Z <dzigterman@chromium.org> | 2020-04-30 14:36:00 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-05 03:35:15 +0000 |
| commit | ab77e89c8e46c743a8644928d42fa30d27f592ae (patch) | |
| tree | 7b46edf5b975a7b4101edd936c6ae835a0c9fb6f | |
| parent | c6626fa92e91e2195a2757435f2765e4b8232d55 (diff) | |
| download | chrome-ec-ab77e89c8e46c743a8644928d42fa30d27f592ae.tar.gz | |
ANX3447: Disable voltage alarms
The ANX3447 may send out large numbers of high voltage alarms, despite
having the vbus high voltage alarm masked off. Disabling all voltage
alarms fixes this issue.
BRANCH=None
BUG=b:153989733
TEST=on waddledee, analogix port may now connect with chargers with no
high voltage alarms triggering
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I399a2ce960f48edfbed215853d487c84ea773e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2174752
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
| -rw-r--r-- | driver/tcpm/anx7447.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/driver/tcpm/anx7447.c b/driver/tcpm/anx7447.c index fa614f5454..0d4be2c477 100644 --- a/driver/tcpm/anx7447.c +++ b/driver/tcpm/anx7447.c @@ -354,6 +354,15 @@ static int anx7447_init(int port) if (rv) return rv; + /* + * Specifically disable voltage alarms, as VBUS_VOLTAGE_ALARM_HI may + * trigger repeatedly despite being masked (b/153989733) + */ + rv = tcpc_update16(port, TCPC_REG_POWER_CTRL, + TCPC_REG_POWER_CTRL_VBUS_VOL_MONITOR_DIS, MASK_SET); + if (rv) + return rv; + /* ADC enable, use to monitor VBUS voltage */ rv = tcpc_read(port, ANX7447_REG_ADC_CTRL_1, ®); if (rv) |