diff options
| author | Roy Mingi Park <roy.mingi.park@intel.com> | 2018-10-10 16:23:57 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-05 12:09:52 +0000 |
| commit | b41fc513222af3574b89c72a1fccaf8284d09890 (patch) | |
| tree | 76151d1986274b2d186edacc436965725b3ec5a2 | |
| parent | c3e6bf302c3c9b8f8af4196ee19e0c3bc732d4c1 (diff) | |
| download | chrome-ec-b41fc513222af3574b89c72a1fccaf8284d09890.tar.gz | |
CHERRY-PICK: nocturne: Add internal pull-downs to unused NVME pins
This change prevents leakage current on NVME
pins and saves around ~0.33mW on nocturne.
BRANCH=nocturne
BUG=b:117139495
TEST=Check npcx EC power to see power improvement
Signed-off-by: Roy Mingi Park <roy.mingi.park@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/1275126
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Mulin Chao <mlchao@nuvoton.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Change-Id: I546dd7100698181ea1549752565fb2f01cff0289
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2160867
Tested-by: Patryk Duda <pdk@semihalf.com>
Commit-Queue: Patryk Duda <pdk@semihalf.com>
| -rw-r--r-- | board/nocturne/board.c | 8 | ||||
| -rw-r--r-- | board/nocturne/gpio.inc | 6 |
2 files changed, 3 insertions, 11 deletions
diff --git a/board/nocturne/board.c b/board/nocturne/board.c index 066a55eb8a..f9a3d59525 100644 --- a/board/nocturne/board.c +++ b/board/nocturne/board.c @@ -345,10 +345,6 @@ const unsigned int chg_cnt = ARRAY_SIZE(chg_chips); void board_chipset_startup(void) { gpio_set_level(GPIO_EN_5V, 1); - gpio_set_level(GPIO_PP3300_NVME_EN, 1); - msleep(2); - gpio_set_level(GPIO_PP1800_NVME_EN, 1); - gpio_set_level(GPIO_PPVAR_NVME_CORE_EN, 1); } DECLARE_HOOK(HOOK_CHIPSET_STARTUP, board_chipset_startup, HOOK_PRIO_DEFAULT); @@ -371,10 +367,6 @@ DECLARE_HOOK(HOOK_CHIPSET_RESUME, board_chipset_resume, HOOK_PRIO_DEFAULT); void board_chipset_shutdown(void) { gpio_set_level(GPIO_EN_5V, 0); - gpio_set_level(GPIO_PPVAR_NVME_CORE_EN, 0); - gpio_set_level(GPIO_PP1800_NVME_EN, 0); - msleep(2); - gpio_set_level(GPIO_PP3300_NVME_EN, 0); } DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_chipset_shutdown, HOOK_PRIO_DEFAULT); diff --git a/board/nocturne/gpio.inc b/board/nocturne/gpio.inc index 08a6539f16..66a4320bf5 100644 --- a/board/nocturne/gpio.inc +++ b/board/nocturne/gpio.inc @@ -74,9 +74,9 @@ GPIO(EC_BL_DISABLE_ODL, PIN(D, 3), GPIO_ODR_HIGH) GPIO(EC_PLATFORM_RST, PIN(8, 6), GPIO_OUT_LOW) GPIO(EC_GPIO31, PIN(3, 1), GPIO_OUT_LOW) GPIO(BASE_PWR_EN, PIN(2, 2), GPIO_OUT_LOW) -GPIO(PP3300_NVME_EN, PIN(2, 1), GPIO_OUT_LOW) -GPIO(PP1800_NVME_EN, PIN(2, 0), GPIO_OUT_LOW) -GPIO(PPVAR_NVME_CORE_EN, PIN(1, 7), GPIO_OUT_LOW) +GPIO(PP3300_NVME_EN, PIN(2, 1), GPIO_INPUT | GPIO_PULL_DOWN) /*NC*/ +GPIO(PP1800_NVME_EN, PIN(2, 0), GPIO_INPUT | GPIO_PULL_DOWN) /*NC*/ +GPIO(PPVAR_NVME_CORE_EN, PIN(1, 7), GPIO_INPUT | GPIO_PULL_DOWN) /*NC*/ GPIO(EC_GPIO16, PIN(1, 6), GPIO_OUT_LOW) GPIO(EC_GPIO15, PIN(1, 5), GPIO_OUT_LOW) GPIO(EC_GPIO14, PIN(1, 4), GPIO_OUT_LOW) |