diff options
| author | Rajat Jain <rajatja@google.com> | 2020-05-05 10:16:24 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-06 00:21:49 +0000 |
| commit | b6ae55365669cdcd6acd1251b26a347cb6cb3510 (patch) | |
| tree | cf88d809abcb699f933c7c25afff69ea0cf7edc3 | |
| parent | f569121906c8c8f95912fcf687d2df7b8832a1c8 (diff) | |
| download | chrome-ec-b6ae55365669cdcd6acd1251b26a347cb6cb3510.tar.gz | |
keyboard_8042: Add comment about KEYBOARD_ROW_REFRESH
Add comment about the need to change KEYBOARD_ROW_REFRESH in case
the refresh key is moved from T3. This existed pre-vivaldi and needs
to be a build time switch because it is used by EC early on, such that
boards will not get a chance at runtime to detect SKU ID or fw_config
and take decisions this early.
BUG=b:146501925
TEST=Build
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: I23ebf1dd567240d6e0dcf4a60ce75090fc9b597b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2182038
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | include/keyboard_8042.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/keyboard_8042.h b/include/keyboard_8042.h index cc15d6aa7d..dd69b5cae0 100644 --- a/include/keyboard_8042.h +++ b/include/keyboard_8042.h @@ -59,6 +59,12 @@ void send_aux_data_to_host(uint8_t data); */ void send_aux_data_to_device(uint8_t data); +/* + * This function can help change the keyboard top row layout as presented to the + * AP. If changing the position of the "Refresh" key from T3, you may also need + * to change KEYBOARD_ROW_REFRESH accordingly so that recovery mode can work on + * the EC side of things (also see related CONFIG_KEYBOARD_REFRESH_ROW3) + */ __override_proto const struct ec_response_keybd_config *board_vivaldi_keybd_config(void); |