diff options
| author | Eric Yilun Lin <yllin@chromium.org> | 2019-12-23 13:37:40 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-12-24 01:46:24 +0000 |
| commit | 28001a83d226a86f176bd92b699586d6c0858196 (patch) | |
| tree | 2f22fbc11de5a55757875566be75b3022ab6413d | |
| parent | 924f9f66d91427c3519a8580ae097af53824be3b (diff) | |
| download | chrome-ec-28001a83d226a86f176bd92b699586d6c0858196.tar.gz | |
rt946x: polish charger log format
Prefix logs with RT946X and add some minor information
TEST=make buildall
BUG=None
BRANCH=kukui
Change-Id: I10992c1d8fbde97eb70bf29c655ea124ce80891f
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1980106
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
| -rw-r--r-- | driver/charger/rt946x.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/driver/charger/rt946x.c b/driver/charger/rt946x.c index e75c2018c1..9ea2a6ac83 100644 --- a/driver/charger/rt946x.c +++ b/driver/charger/rt946x.c @@ -28,7 +28,8 @@ /* Console output macros */ #define CPRINTF(format, args...) cprintf(CC_CHARGER, format, ## args) -#define CPRINTS(format, args...) cprints(CC_CHARGER, format, ## args) +#define CPRINTS(format, args...) \ + cprints(CC_CHARGER, "%s " format, "RT946X", ## args) /* Charger parameters */ static const struct charger_info rt946x_charger_info = { @@ -978,7 +979,7 @@ int charger_set_hw_ramp(int enable) * The vendor suggests setting AICL_VTH as (MIVR + 200mV). */ if ((mivr + 200) > RT946X_AICLVTH_MAX) { - CPRINTS("no suitable vth, %d", mivr); + CPRINTS("mivr(%d) too high", mivr); return EC_ERROR_INVAL; } @@ -1020,7 +1021,7 @@ static void rt946x_init(void) { int ret = rt946x_init_setting(); - CPRINTS("RT946X init %s(%d)", ret ? "fail" : "success", ret); + CPRINTS("init %s(%d)", ret ? "fail" : "good", ret); } DECLARE_HOOK(HOOK_INIT, rt946x_init, HOOK_PRIO_INIT_I2C + 1); @@ -1324,7 +1325,7 @@ int rt946x_get_adc(enum rt946x_adc_in_sel adc_sel, int *adc_val) if (adc_sel == RT946X_ADC_VBUS_DIV5) adc_result = ((adc_data_h << 8) | adc_data_l) * 25; else - CPRINTS("unsupported channel"); + CPRINTS("unsupported channel %d", adc_sel); *adc_val = adc_result; #elif defined(CONFIG_CHARGER_MT6370) /* Calculate ADC value */ @@ -1399,7 +1400,7 @@ static int mt6370_pmu_chg_mivr_irq_handler(void) return rv; if (!mivr_stat) { - CPRINTS("mivr inact"); + CPRINTS("no mivr stat"); return rv; } |