diff options
| author | Eric Herrmann <eherrmann@chromium.org> | 2019-12-12 15:30:58 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-12-14 02:37:08 +0000 |
| commit | 3ab34313d8f3916cf15f9b30b5e7157a6938b597 (patch) | |
| tree | 572ad609902fe19b3c74c12ca2e2b2e11ab4f0dd | |
| parent | b0bb3ce2a0e077108e5df2966f13b4d6a024b3d5 (diff) | |
| download | chrome-ec-3ab34313d8f3916cf15f9b30b5e7157a6938b597.tar.gz | |
ISL9241: Change register settings for OCP
Register setting on the ISL9241 were causing overcurrent protection
(OCP) to be triggered.
ACILIM2 doesn't seem to be working properly, causing current spikes. 2
level current limiting isn't necessary so is disabled.
This was likely not seen on other platforms because SYV682 current limit
is much more sensitive to spikes than other Type-C PPCs.
BUG=b:145562693
BRANCH=none
TEST=make buildall
TEST=ensure that the Port C1 begins charging at 3A after plugging in
TEST=check that the Port C1 continues charging at 3A while system at
full load with battery
Change-Id: Idee24b1215527b8e6ad8651285664e29c3d1c3f4
Signed-off-by: Eric Herrmann <eherrmann@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1966672
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Tested-by: Eric Herrmann <eherrmann@google.com>
Commit-Queue: Eric Herrmann <eherrmann@google.com>
| -rw-r--r-- | driver/charger/isl9241.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/driver/charger/isl9241.c b/driver/charger/isl9241.c index 1c89db9601..ce40fac353 100644 --- a/driver/charger/isl9241.c +++ b/driver/charger/isl9241.c @@ -329,13 +329,11 @@ static void isl9241_init(void) /* * Set control2 register to * [15:13]: Trickle Charging Current (battery pre-charge current) - * [12] : Two-Level Adapter Current Limit (enable) * [10:9] : Prochot# Debounce time (1000us) */ if (isl9241_update(ISL9241_REG_CONTROL2, (ISL9241_CONTROL2_TRICKLE_CHG_CURR( - bi->precharge_current) | - ISL9241_CONTROL2_TWO_LEVEL_ADP_CURR | + bi->precharge_current) | ISL9241_CONTROL2_PROCHOT_DEBOUNCE_1000), MASK_SET)) goto init_fail; |